Refactor: Make HideChannel option stateless

The `HideChannel` option in `ChatInfoItem` has been changed from a `Stateful` option to a regular `Option`. This simplifies the logic in `ChatInfoFragment` and `GroupChatInfoFragment` by removing the need to manually update the option's checked state when a modal is dismissed.

The click handling for the `HideChannel` option has been updated to reflect this change. It now checks the current `isChecked` state of the option to determine whether to trigger `HideChannelClick` or `UnhideChannelClick`.

Author: andremion

stream-chat-android-ui-components-sample/src/main/kotlin/io/getstream/chat/ui/sample/feature/chat/info/ChatInfoExtensions.kt

@@ -58,7 +58,7 @@ internal fun List<ChannelInfoViewState.Content.Option>.toChannelInfoItems(
             )
 
             is ChannelInfoViewState.Content.Option.HideChannel -> add(
-                ChatInfoItem.Option.Stateful.HideChannel(
+                ChatInfoItem.Option.HideChannel(
                     textResId = if (isGroupChannel) {
                         R.string.stream_ui_channel_info_option_hide_group
                     } else {

stream-chat-android-ui-components-sample/src/main/kotlin/io/getstream/chat/ui/sample/feature/chat/info/ChatInfoFragment.kt

@@ -93,14 +93,7 @@ class ChatInfoFragment : Fragment() {
             when (event) {
                 is ChannelInfoViewEvent.Error -> showError(event, isGroupChannel = false)
                 is ChannelInfoViewEvent.Navigation -> onNavigationEvent(event)
-                is ChannelInfoViewEvent.Modal -> showModal(event, viewModel, isGroupChannel = false) { modal ->
-                    if (modal is ChannelInfoViewEvent.HideChannelModal) {
-                        // If the HideChannel modal was dismissed,
-                        // we need to revert the state of the HideChannel option to unchecked,
-                        // as it was checked when the modal was shown.
-                        binding.optionsRecyclerView.adapter?.notifyDataSetChanged()
-                    }
-                }
+                is ChannelInfoViewEvent.Modal -> showModal(event, viewModel, isGroupChannel = false)
             }
         }
     }
@@ -141,13 +134,6 @@ class ChatInfoFragment : Fragment() {
                         } else {
                             ChannelInfoViewAction.UnmuteChannelClick
                         }
-
-                    is ChatInfoItem.Option.Stateful.HideChannel ->
-                        if (isChecked) {
-                            ChannelInfoViewAction.HideChannelClick
-                        } else {
-                            ChannelInfoViewAction.UnhideChannelClick
-                        }
                 },
             )
         }
@@ -176,10 +162,16 @@ class ChatInfoFragment : Fragment() {
                 is ChatInfoItem.Option.DeleteChannel ->
                     viewModel.onViewAction(ChannelInfoViewAction.DeleteChannelClick)
 
+                is ChatInfoItem.Option.HideChannel -> viewModel.onViewAction(
+                    if (option.isChecked) {
+                        ChannelInfoViewAction.UnhideChannelClick
+                    } else {
+                        ChannelInfoViewAction.HideChannelClick
+                    },
+                )
+
                 // Already handled
-                is ChatInfoItem.Option.Stateful.MuteChannel,
-                is ChatInfoItem.Option.Stateful.HideChannel,
-                -> Unit
+                is ChatInfoItem.Option.Stateful.MuteChannel -> Unit
             }
         }
     }

stream-chat-android-ui-components-sample/src/main/kotlin/io/getstream/chat/ui/sample/feature/chat/info/ChatInfoItem.kt

@@ -101,6 +101,19 @@ sealed class ChatInfoItem {
             override val showRightArrow: Boolean = false
         }
 
+        data class HideChannel(
+            @StringRes override val textResId: Int,
+            val isChecked: Boolean,
+        ) : Option() {
+            override val iconResId: Int
+                get() = R.drawable.stream_ic_hide
+
+            override val showRightArrow: Boolean = false
+
+            override val checkedState: Boolean
+                get() = isChecked
+        }
+
         sealed class Stateful : Option() {
             abstract val isChecked: Boolean
 
@@ -111,14 +124,6 @@ sealed class ChatInfoItem {
                 override val iconResId: Int
                     get() = R.drawable.ic_mute
             }
-
-            data class HideChannel(
-                @StringRes override val textResId: Int,
-                override var isChecked: Boolean,
-            ) : Stateful() {
-                override val iconResId: Int
-                    get() = R.drawable.stream_ic_hide
-            }
         }
     }
 }

stream-chat-android-ui-components-sample/src/main/kotlin/io/getstream/chat/ui/sample/feature/chat/info/group/GroupChatInfoFragment.kt

@@ -106,14 +106,7 @@ class GroupChatInfoFragment : Fragment() {
             when (event) {
                 is ChannelInfoViewEvent.Error -> showError(event, isGroupChannel = true)
                 is ChannelInfoViewEvent.Navigation -> onNavigationEvent(event)
-                is ChannelInfoViewEvent.Modal -> showModal(event, viewModel, isGroupChannel = true) { modal ->
-                    if (modal is ChannelInfoViewEvent.HideChannelModal) {
-                        // If the HideChannel modal was dismissed,
-                        // we need to revert the state of the HideChannel option to unchecked,
-                        // as it was checked when the modal was shown.
-                        binding.optionsRecyclerView.adapter?.notifyDataSetChanged()
-                    }
-                }
+                is ChannelInfoViewEvent.Modal -> showModal(event, viewModel, isGroupChannel = true)
             }
         }
         viewModel.state.observe(viewLifecycleOwner) { state ->
@@ -183,13 +176,6 @@ class GroupChatInfoFragment : Fragment() {
                         } else {
                             ChannelInfoViewAction.UnmuteChannelClick
                         }
-
-                    is ChatInfoItem.Option.Stateful.HideChannel ->
-                        if (isChecked) {
-                            ChannelInfoViewAction.HideChannelClick
-                        } else {
-                            ChannelInfoViewAction.UnhideChannelClick
-                        }
                 },
             )
         }
@@ -200,7 +186,6 @@ class GroupChatInfoFragment : Fragment() {
                 ChatInfoItem.Option.SharedMedia -> findNavController().navigateSafely(
                     GroupChatInfoFragmentDirections.actionGroupChatInfoFragmentToChatInfoSharedMediaFragment(args.cid),
                 )
-
                 ChatInfoItem.Option.SharedFiles -> findNavController().navigateSafely(
                     GroupChatInfoFragmentDirections.actionGroupChatInfoFragmentToChatInfoSharedFilesFragment(args.cid),
                 )
@@ -211,13 +196,19 @@ class GroupChatInfoFragment : Fragment() {
                 is ChatInfoItem.Option.DeleteChannel ->
                     viewModel.onViewAction(ChannelInfoViewAction.DeleteChannelClick)
 
+                is ChatInfoItem.Option.HideChannel -> viewModel.onViewAction(
+                    if (option.isChecked) {
+                        ChannelInfoViewAction.UnhideChannelClick
+                    } else {
+                        ChannelInfoViewAction.HideChannelClick
+                    },
+                )
+
                 // Not applicable in this UI
                 ChatInfoItem.Option.SharedGroups -> Unit
 
                 // Already handled
-                is ChatInfoItem.Option.Stateful.MuteChannel,
-                is ChatInfoItem.Option.Stateful.HideChannel,
-                -> Unit
+                is ChatInfoItem.Option.Stateful.MuteChannel -> Unit
             }
         }
         adapter.setMemberClickListener { viewModel.onViewAction(ChannelInfoViewAction.MemberClick(it)) }