Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconBadge showNumber prop is incorrectly typed #171

Open
wodow opened this issue Jan 28, 2021 · 0 comments
Open

IconBadge showNumber prop is incorrectly typed #171

wodow opened this issue Jan 28, 2021 · 0 comments

Comments

@wodow
Copy link

wodow commented Jan 28, 2021

IconBadge defines

  showNumber: PropTypes.number,

yet its default is false, at https://github.com/GetStream/react-native-activity-feed/blob/master/src/components/IconBadge.js#L16 and treated like a boolean at https://github.com/GetStream/react-native-activity-feed/blob/master/src/components/IconBadge.js#L53

Should be PropTypes.bool ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wodow