Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Open Angel Arena #97

Open
Chronophylos opened this issue May 5, 2017 · 20 comments
Open

[SCHEMA] Open Angel Arena #97

Chronophylos opened this issue May 5, 2017 · 20 comments

Comments

@Chronophylos
Copy link

Console log: https://hastebin.com/aqazeyusid.txt
settings.kv: https://hastebin.com/karizijeci.scala
schema.lua: https://hastebin.com/aviceqefaj.lua
addon_game_mode.lua: https://hastebin.com/wiwufoqozo.lua

Other files that defines functions we pull stats from:

@jimmydorry
Copy link
Member

I don't see gl and wt in your console log. If your schema doesn't work, check that they actually appear in the log.

gl must be an integer. Use math.floor(GAME_TIME_ELAPSED)


Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=156

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema ID starts with XX... not a v1

@Chronophylos
Copy link
Author

Thanks!
I fixed it: https://hastebin.com/yixucehori.md
Can you change Team 1 Caves and Team 2 Caves to Team 1 Cave Cleares and Team 2 Cave Cleares and set their objective to Maximise?

@jimmydorry
Copy link
Member

Done. Changing the field display names doesn't change the schema version.

@Chronophylos
Copy link
Author

Thank you.

@Chronophylos
Copy link
Author

We set up the settings.kv correctly but on getdotastats.com no entries appear, even after the update. Do you know what the problem could be?

@jimmydorry
Copy link
Member

No clue. Check your console log, as it will list the error.

The most common causes are:

  • wrong schemaID (they do not start with the version number, e.g. V1). Double check your settings.kv!
  • missing fields in the schema (fields defined in the schema on the site, but not defined in the mod schema.lua). Double check your schema!
  • overlapping field names (using a field name twice, e.g. pk). Point it out and get a new schema issued.

@Chronophylos
Copy link
Author

Can you do some changes in the schema?

  • Set Score Limit to not Groupable
  • Set Item List to no Graph

@jimmydorry
Copy link
Member

Done

@Chronophylos
Copy link
Author

Thanks

@Haganeko
Copy link

Is it possible to purge the Game/Player Values stats after major updates? I don't know whether this is possible or happens automatically or something, but otherwise it'll be harder to see the balance impacts of changes.

@jimmydorry
Copy link
Member

The two options are to wait a week (you need the new data anyway), or to get a new schemaID (request a small change to the schema and automatically get a new schemaID).

@Haganeko
Copy link

Ah. So it resets automatically every week. Thank you!

@jimmydorry
Copy link
Member

It's a rolling window of up to the last week of stats. Add a new flag to track version to see how much of the data is reported from which version.

@jimmydorry
Copy link
Member

Look at what CIA and other mods have done. https://getdotastats.com/#s2__mod_f?id=137

statCollection:setFlags({version = '4.20'})

@Chronophylos
Copy link
Author

We are setting such a flag

@Chronophylos
Copy link
Author

Also, is there a way to get our stats from your server?

@jimmydorry
Copy link
Member

Doesn't look like you are setting a version flag. This is a recent game. https://getdotastats.com/#s2__match?id=23578219

As to getting data. I sometimes do a data dump on request, but the data won't be much use to you raw.

@Chronophylos
Copy link
Author

Hm, we're setting the flag in customSchema:init() like in the example

@jimmydorry
Copy link
Member

jimmydorry commented Jun 12, 2017

Test in a local game, and see what gets reported. You'll know via console log (it says something like flag successfully set) as well as via the site, if it works. You may have done it all perfectly, but Steam is simply not serving up your update to some clients (i.e. they haven't restarted dota).

Putting it in customSchema:init() may end up being too late. You need to set it after the library is loaded but before the game starts. The best time to do it is during hero selection where mods typically allow players to vote on game options.

LoD Redux

CIA

@Chronophylos
Copy link
Author

Thanks, I'll try putting it somewhere earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants