Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omero-rdf to conda-forge #12

Open
marimeireles opened this issue May 14, 2024 · 10 comments
Open

Add omero-rdf to conda-forge #12

marimeireles opened this issue May 14, 2024 · 10 comments
Assignees

Comments

@marimeireles
Copy link

marimeireles commented May 14, 2024

Hey @joshmoore thank you for the project!
I'm currently using it to integrate MPI's evolutionary biology databases.

I'm wondering if you're interested in having the package over at conda-forge.
I'm a contributor there and can easily do it, it really doesn't require any extra work for you other than tagging each new version you release with a commit tag.

So for example, for version 1.0 in pipy, on github you'd have to have:

git tag -a v1.0 -m "Tagging version 1.0"
git push origin v1.0

By keeping the commits tagged, a bot will automatically pick up the new versions from your repository and create a PR on the conda-forge side. And then someone has to check everything is alright and merge (this could me, you or other contributors).

I'll be happy to do the port and maintain the package.

Thanks for your work with OMERO!

@marimeireles
Copy link
Author

Oh, sorry about that, I just noticed that the repo is already tagged. So no extra work would be necessary.
Best!

@joshmoore
Copy link
Member

I'm wondering if you're interested in having the package over at conda-forge.

Sure! Please feel free to add me as an additional maintainer and thanks!

@marimeireles
Copy link
Author

Hey @joshmoore happy to contribute back! : )

Just so you're up to date this might take a little while. I've identified a couple of other missing dependencies that omero-rdf depends on:

  - types-entrypoints
  - omero-marshal
  - wikidataintegrator
      - pyshex
          - cfgraph 
          - pyshexc 
              - pyjsg
              - rdflib-shim
              - shexjsg
                - pyjsg
          - rdflib-shim
          - shexjsg
          - sparqlslurper
            - rdflib-shim
      - mwoauth [error]
      - shexer
        - wlighter

I've created packages for all the missing dependencies and I'll open PRs on conda-forge to have them merged soon. However I had an issue with mwoauth. Might be a little trickier. Once it's done I'll update this issue again.

Best!

@joshmoore
Copy link
Member

Wow. Thanks, @marimeireles. FWIW, an option would likely to make some of these optional dependencies if that would make your life substantially easier.

@marimeireles
Copy link
Author

Hi @joshmoore thanks for the offer.
However, I believe these types-entrypoints, omero-marshal, wikidataintegrator are pivotal for the functioning of omero-rdf, correct? If they are, then there's hardly anything we can do other than wait for the packages to be integrated.
I'll give another push on this effort today. I think 1 or 2 of the packages were merged by now.
Best,

@joshmoore
Copy link
Member

joshmoore commented Jul 26, 2024

pivotal for functioning conda-forge plan
omero-marshal yes (https://github.com/conda-forge/omero-marshal-feedstock/pull/2/files) happy to take over maintainership of a feedstock
types-entrypoints needs a workaround (#33) Bit surprised it's not
wikidataintegrator could be (optionally) avoided (#35) No idea

@joshmoore
Copy link
Member

@tstoeter see https://github.com/conda-forge/staged-recipes/pulls/marimeireles for other attempts to add required libraries.

@joshmoore
Copy link
Member

Think that's everything done from my side, @marimeireles. Please let me know if there's anything else you need.

@marimeireles
Copy link
Author

marimeireles commented Dec 12, 2024

Cool, thanks Josh. I'm working on it.
Should we re-open this?

We need to remove the following packages from the pyproject rdflib-pyld-compat and wikidataintegrator:

omero-rdf/pyproject.toml

Lines 26 to 28 in 22557cf

"rdflib-pyld-compat",
"omero-marshal",
"wikidataintegrator",

Also, apparently I made a mistake, and we're still missing rdflib-pyld-compat from conda-forge. I'm assuming we need this one? Or is it also possible to remove it?

@joshmoore
Copy link
Member

rdflib-pyld-compat we'l need. I forgot to remove wikidataintegrator. Thanks to @tstoeter for #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants