-
Notifications
You must be signed in to change notification settings - Fork 3
update static layer paths and versioning #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
caitlinadams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is a big improvement in terms of how the logic works for managing the metadata, partcularly when it comes to S3 paths. Do you need to update the documentation in line with these changes at all?
| f"DEM type URL map: {DEM_TYPE_URL}. Matches: {dem_type_matches}" | ||
| ) | ||
| raise ValueError( | ||
| f"Expected exactly one DEM type match, found {len(dem_type_matches)}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth saying what the matches were? Or is it sufficient to be told there was an incorrect number of matches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, addressed - c55a79c
Yes I do. Thanks I missed that actually! |
caitlinadams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for making the changes!
dem_typeandstatic_layer_validity_start_date. This is required to future proof the pipeline if changes are ever made to the dem (e.g. consideration of timeseries) or the orbit / aquisition scenario of the sentinel-1 mission changes (for example, the orbit is lowered in late life or the orbit is no longer stable and the assumption of static layers is invalid)."{s3_project_folder}/{odc_product_name}/{burst_id}/{burst_st_year}/{burst_st_month}/{burst_st_day}/{burst_st}""{s3_project_folder}/{odc_product_name}/{burst_id}/{static_layer_validity_start_date}/{dem_type}"burst_st) references theazimuth_timeof the burst. This is different to the acquisition start time.datetime=azimuth_timeorzero_doppler_start_timestart_datetime=BeginningDateTimefrom CDSE API, this is consistent with thestartTimefrom the ASF APIend_datetime=EndingDateTimefrom CDSE API, this is not consistent with thestopTimefrom the ASF APIsarard:azimuth_timesarard:zero_doppler_start_timesarard:zero_doppler_end_timedataAccesslinks defined in the config.