Skip to content

Commit 8d4db84

Browse files
authored
[Bug] the sample list items are overflow the notebook container (#2502)
1 parent 57bf460 commit 8d4db84

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

BuildTools/macosx/GNUmakefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,18 +112,18 @@ build-geoda-mac:
112112
cp /usr/local/opt/proj/share/proj/deformation_model.schema.json build/GeoDa.app/Contents/Resources/proj
113113
cp /usr/local/opt/proj/share/proj/triangulation.schema.json build/GeoDa.app/Contents/Resources/proj
114114
cp /usr/local/opt/proj/share/proj/world build/GeoDa.app/Contents/Resources/proj
115-
cp libraries/lib/libwx_osx_cocoau-3.2.0.2.2.dylib build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau-3.2.dylib
116-
cp libraries/lib/libwx_osx_cocoau_gl-3.2.0.2.2.dylib build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau_gl-3.2.dylib
115+
cp libraries/lib/libwx_osx_cocoau-3.2.0.3.0.dylib build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau-3.2.dylib
116+
cp libraries/lib/libwx_osx_cocoau_gl-3.2.0.3.0.dylib build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau_gl-3.2.dylib
117117
cp /usr/local/opt/gdal/lib/libgdal.35.dylib build/GeoDa.app/Contents/Frameworks
118118
install_name_tool -id "GeoDa" build/GeoDa.app/Contents/MacOS/GeoDa
119-
install_name_tool -change "$(GEODA_HOME)/libraries/lib/libwx_osx_cocoau_gl-3.2.dylib" "@executable_path/../Frameworks/libwx_osx_cocoau_gl-3.2.dylib" build/GeoDa.app/Contents/MacOS/GeoDa
120-
install_name_tool -change "$(GEODA_HOME)/libraries/lib/libwx_osx_cocoau-3.2.dylib" "@executable_path/../Frameworks/libwx_osx_cocoau-3.2.dylib" build/GeoDa.app/Contents/MacOS/GeoDa
119+
install_name_tool -change "$(GEODA_HOME)/libraries/lib/libwx_osx_cocoau_gl-3.2.0.3.0.dylib" "@executable_path/../Frameworks/libwx_osx_cocoau_gl-3.2.dylib" build/GeoDa.app/Contents/MacOS/GeoDa
120+
install_name_tool -change "$(GEODA_HOME)/libraries/lib/libwx_osx_cocoau-3.2.0.3.0.dylib" "@executable_path/../Frameworks/libwx_osx_cocoau-3.2.dylib" build/GeoDa.app/Contents/MacOS/GeoDa
121121
install_name_tool -change "/usr/local/opt/gdal/lib/libgdal.35.dylib" "@executable_path/../Frameworks/libgdal.35.dylib" build/GeoDa.app/Contents/MacOS/GeoDa
122122
install_name_tool -change "/opt/homebrew/opt/gdal/lib/libgdal.35.dylib" "@executable_path/../Frameworks/libgdal.35.dylib" build/GeoDa.app/Contents/MacOS/GeoDa
123123
python3 install_name.py $(GEODA_HOME)/build/GeoDa.app/Contents/Frameworks "Developer ID Application: Geodapress LLC (26M5NG43GP)"
124-
install_name_tool -change "@executable_path/../Frameworks/libwx_osx_cocoau-3.2.0.2.2.dylib" "@executable_path/../Frameworks/libwx_osx_cocoau-3.2.dylib" build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau_gl-3.2.dylib
124+
install_name_tool -change "@executable_path/../Frameworks/libwx_osx_cocoau-3.2.0.3.0.dylib" "@executable_path/../Frameworks/libwx_osx_cocoau-3.2.dylib" build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau_gl-3.2.dylib
125125
codesign -f --timestamp -o runtime -s "Developer ID Application: Geodapress LLC (26M5NG43GP)" build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau_gl-3.2.dylib
126-
codesign -f --timestamp -o runtime -s "Developer ID Application: Geodapress LLC (26M5NG43GP)" build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau-3.2.0.2.2.dylib
126+
codesign -f --timestamp -o runtime -s "Developer ID Application: Geodapress LLC (26M5NG43GP)" build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau-3.2.0.3.0.dylib
127127
codesign -f --timestamp -o runtime -s "Developer ID Application: Geodapress LLC (26M5NG43GP)" build/GeoDa.app/Contents/Frameworks/libwx_osx_cocoau-3.2.dylib
128128
codesign -f --timestamp -o runtime -s "Developer ID Application: Geodapress LLC (26M5NG43GP)" build/GeoDa.app/Contents/MacOS/lisa_kernel.cl
129129
codesign -f --timestamp -o runtime -s "Developer ID Application: Geodapress LLC (26M5NG43GP)" build/GeoDa.app/Contents/MacOS/GeoDa

BuildTools/macosx/install.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ if ! [ -f "../libraries/lib/libboost_thread.a" ]; then
6161
cd ..
6262
fi
6363

64-
# Build wxWidgets 3.2.4
65-
if ! [ -f "wxWidgets-3.2.4.tar.bz2" ]; then
66-
curl -L -O https://github.com/wxWidgets/wxWidgets/releases/download/v3.2.4/wxWidgets-3.2.4.tar.bz2
67-
tar -xf wxWidgets-3.2.4.tar.bz2
64+
# Build wxWidgets 3.2.6
65+
if ! [ -f "wxWidgets-3.2.6.tar.bz2" ]; then
66+
curl -L -O https://github.com/wxWidgets/wxWidgets/releases/download/v3.2.6/wxWidgets-3.2.6.tar.bz2
67+
tar -xf wxWidgets-3.2.6.tar.bz2
6868
fi
6969
if ! [ -f "../libraries/bin/wx-config" ]; then
70-
cd wxWidgets-3.2.4
70+
cd wxWidgets-3.2.6
7171
./configure --with-cocoa --with-opengl --enable-postscript --enable-textfile --without-liblzma --enable-webview --enable-cxx11 --disable-mediactrl --enable-webviewwebkit --enable-monolithic --with-libtiff=builtin --with-libpng=builtin --with-libjpeg=builtin --prefix=$GEODA_HOME/libraries
7272
make -j $CPUS
7373
make install

DialogTools/ConnectDatasourceDlg.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -966,19 +966,19 @@ void ConnectDatasourceDlg::InitSamplePanel() {
966966
sample_scrl->SetBackgroundColour(*wxWHITE);
967967
#endif
968968
{
969-
wxBoxSizer* sizer;
970-
sizer = new wxBoxSizer(wxVERTICAL);
969+
wxBoxSizer* sample_sizer;
970+
sample_sizer = new wxBoxSizer(wxVERTICAL);
971971
for (size_t i = 0; i < GdaConst::sample_names.size(); i++) {
972972
wxString sample_name = GdaConst::sample_names[i];
973973
wxString sample_meta_url = GdaConst::sample_meta_urls[i];
974974
wxString ds_layername = GdaConst::sample_layer_names[i];
975975
wxString ds_thumb = GdaConst::sample_layer_names[i];
976-
AddSampleItem(sizer, sample_scrl, sample_name, sample_meta_url, ds_layername, ds_thumb,
976+
AddSampleItem(sample_sizer, sample_scrl, sample_name, sample_meta_url, ds_layername, ds_thumb,
977977
base_xrcid_sample_thumb + static_cast<int>(i));
978978
}
979-
sample_scrl->SetSizer(sizer);
979+
sample_scrl->SetSizer(sample_sizer);
980980
sample_scrl->Layout();
981-
sizer->Fit(sample_scrl);
981+
sample_sizer->Fit(sample_scrl);
982982
}
983983

984984
sizer->Add(sample_scrl, 1, wxEXPAND | wxRIGHT, 5);

0 commit comments

Comments
 (0)