Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer modifies user's .bashrc without asking or warning the user #19

Open
KirillKryukov opened this issue May 13, 2020 · 2 comments

Comments

@KirillKryukov
Copy link

Running GTZ installer "https://gtz.io/gtz_latest.run" modifies user's .bashrc file. This intrusion into user's configuration happens silently, without asking, warning or notifying the user.

Few reasons why it's a bad idea:

  1. It's extremely rude to silently mess with user's configuration files.
  2. User may prefer other shell such as zsh (please don't get any ideas).
  3. User may prefer to run gtz using full path, or configure their own aliases or symlinks.
  4. User may already have another command with the same name.

Fortunately && source ~/.bashrc in installation instructions gives it away.

This happens as of GTZ version "PROFESSIONAL-2.1.3-V-2020-03-18 07:11:20"

@bolunfeng
Copy link
Contributor

We modify the .bashrc so that users without root permissions can use it directly after installation.Of course, we did ignore the necessary notifying,and we will add it into the next release.Thank you very much!

@KirillKryukov
Copy link
Author

Thanks. I note that this (or any other) issue should not be closed until it has been fixed.

@bolunfeng bolunfeng reopened this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants