Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setuptools's "platforms" metadata with classifiers #3744

Open
seisman opened this issue Jan 3, 2025 · 0 comments
Open

Replace setuptools's "platforms" metadata with classifiers #3744

seisman opened this issue Jan 3, 2025 · 0 comments
Labels
good first issue Good for newcomers help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Jan 3, 2025

We have the platforms metadata defined in the tool.setuptools section of pyproject.toml. The metadata has been defined since the start of the project (e.g., in v0.1a1: https://github.com/GenericMappingTools/pygmt/blob/2963f624371da4c8858df115b5703a7cc13602ac/setup.py).

pygmt/pyproject.toml

Lines 56 to 58 in 4b9314a

[tool.setuptools]
platforms = ["Any"]
license-files = ["LICENSE.txt"]

If I remember correctly, this metadata was previously shown on PyPI, but it's not shown anymore (see https://pypi.org/project/pygmt, but I can't find any discussions about deprecating this metadata).

Looking at other projects, I think the standard way is to use classifiers instead (xref: https://pypi.org/classifiers/).

xarray/pandas use the Operating System :: OS Independent classifier, while numpy uses detailed classifiers like Operating System :: MacOS.

I prefer the numpy style and propose to add the following classifiers (xref: https://pypi.org/classifiers/)

  • Operating System :: MacOS
  • Operating System :: Microsoft :: Windows
  • Operating System :: POSIX
  • Operating System :: Unix
@seisman seisman added discussions Need more discussion before taking further actions good first issue Good for newcomers help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs and removed discussions Need more discussion before taking further actions labels Jan 3, 2025
@seisman seisman added this to the 0.15.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Projects
None yet
Development

No branches or pull requests

1 participant