Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The R checks for CoxPH fail with survival package 2.39.2 #27

Open
lckarssen opened this issue Apr 23, 2016 · 2 comments
Open

The R checks for CoxPH fail with survival package 2.39.2 #27

lckarssen opened this issue Apr 23, 2016 · 2 comments

Comments

@lckarssen
Copy link
Member

The R checks for Cox' proportional hazards model (run_R_test_pacoxph) fail with version 2.39.2 of the R survival package:

./run_R_test_pacox.sh 
Checking Cox PH regression...
Loading required package: survival
Dose: check consistency of names                  OK
Prob: check consistency of names                  OK
Check consistency dose <-> prob gtdata            OK
Running ProbABEL...                               OK
Comparing R output with ProbABEL output:
 additive (dosages)                               OK
 additive (probabilities)                         OK
 dominant                                         OK
 recessive                                        OK
 overdominant                                     OK
 2df                                              OK

Run the same checks, but without any covariates (see bug #1266)
Running ProbABEL...                               OK
Comparing R output with ProbABEL output:
 additive (dosages)                               OK
 additive (probabilities)                         OK
 dominant                                         Error in summary(model[[1]])$coefficients : 
  $ operator is invalid for atomic vectors
Calls: run.model
Execution halted

This is on the current HEAD of master (commit 6d23885), but also for ProbABEL v0.4.5. On the Jenkins server the tests pass, the version number of the survival package there is 2.38.3.

@lckarssen lckarssen added the bug label Apr 23, 2016
@lckarssen lckarssen added this to the v0.5.0 milestone Apr 23, 2016
@lckarssen lckarssen modified the milestones: v1.0.0, v0.5.0 May 3, 2016
@lckarssen
Copy link
Member Author

Since the checks pass with Survival v2.38.3, I have moved the milestone from v0.5.0 to v1.0.0, so that this issue doesn't delay the release of v0.5.0.

lckarssen added a commit that referenced this issue May 4, 2016
This is a temporary (!) workaround for Issue #27. This is only so we can
release v0.5.0 without further delay, knowing that with R's Survival
package v2.38.2 the check passes.
lckarssen added a commit that referenced this issue May 4, 2016
This is a temporary (!) workaround for Issue #27. This is only so we can
release v0.5.0 without further delay, knowing that with R's Survival
package v2.38.2 the check passes.
@lckarssen
Copy link
Member Author

The differences between v2.38-3 and v2.29-2 of the Survival package can be found here on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant