Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate checks #94

Open
mariakimheinert opened this issue Aug 4, 2022 · 0 comments
Open

Validate checks #94

mariakimheinert opened this issue Aug 4, 2022 · 0 comments
Labels
enhancement New feature or request help-wanted

Comments

@mariakimheinert
Copy link
Member

mariakimheinert commented Aug 4, 2022

In the future, we may want to add a warning if we get a check in the checks array that we cannot run.

Originally posted by @Michionlion in #91 (comment)

Currently, in gatorgrade/input/command_line_generator.py, we read in the data assuming that the user has provided a correctly formatted gatorgrade.yml file. If checks are improperly formatted (e.g. a shell check does not contain a command value), we allow them to fail at the "run" phase, which occurs in gatorgrade/output/output.py. We may want to add validation of checks at the "read" phase (i.e. in command_line_generator.py) that ensures that the gatorgrade.yml file contains all necessary data for each check and provides information to the user if it does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted
Projects
None yet
Development

No branches or pull requests

1 participant