Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints #93

Open
mariakimheinert opened this issue Jul 23, 2022 · 3 comments · May be fixed by #99
Open

Add type hints #93

mariakimheinert opened this issue Jul 23, 2022 · 3 comments · May be fixed by #99
Assignees

Comments

@mariakimheinert
Copy link
Member

We have started adding type hints with PR #91. For maintainability, we should add type hints (at least for all function inputs and outputs) throughout the entire system. Because the system is relatively small, this would be a great onboarding task for a new maintainer as it will help them develop an understanding of the system's architecture.

@mariakimheinert
Copy link
Member Author

@Yanqiao4396 or @Ochirsaikhan, might this be something you would be interested in doing?

@gkapfham
Copy link
Collaborator

gkapfham commented Aug 3, 2022

Hi @Yanqiao4396 and @Ochirsaikhan, I wanted to follow up with you again to see if you are interested in adding type annotations to the GatorGrade code base?

@Yanqiao4396
Copy link
Contributor

Sorry for the late reply, I didn't turn on the notification on Github. After checking that, I feel I can do it these days. I can promise to finish that within 7 days

@Yanqiao4396 Yanqiao4396 self-assigned this Aug 19, 2022
@Yanqiao4396 Yanqiao4396 linked a pull request Aug 24, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants