-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatic PyPI Publishing using Tags and add Auto Releasing #148
base: main
Are you sure you want to change the base?
Conversation
…blish workflow so both exist
This PR needs a secret key to work in the I lack experience in Pypi and needed to approve this. Potentially another TL could help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PCain02, please confirm that this feature works on macOS. I see you’ve tested it on Windows, and Rebekah confirmed it on Linux. We just need a macOS test to complete the cross-platform verification. The feature looks great, and I don’t see any issues with the implementation. One question for clarification: does any instance of a v tag trigger a release to PyPI, or only when that tag is committed to the main branch? For instance, if someone on a feature branch uses a v tag, would it publish to PyPI without being merged into main? Thank you for clarifying, and I apologize if it’s a basic question! |
Hello @PCain02 can you seek out confirmation that this works if the person who performs the release is running MacOS, as @AlishChhetri has suggested? |
This is a super interesting question and I did not even think of that. I just tested it and yes it does seem you can tag in any branch and publish it to PyPI. I never even considered this as an issue but would it be better if there was some sort of check that the person is in the main branch before publishing? Thanks for bringing this to my attention! |
Yes! I added @Chezka109 @hemanialaparthi and @dyga01 all MacOS users very good at testing. If they would be so kind I would appreciate the testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic PyPI Publishing using Tags and add Auto Releasing
Description
YOU SHOULD TEST THIS IN YOUR OWN FORK
This PR adds the ability to publish to PyPI automatically when using tags.
tag_publish.yml
andtest-publish.yml
were the main targets of the PR. The lowercaset
tag will be used for test publishing and the lowercasev
tag is for real publishing. They should look like t0.7.1 and v0.7.1The commands to use this are as follows where the version number is replaced with the next sequential version.
poetry version 0.3.1
git add pyproject.toml
git commit -m "Chore: Bump version to 0.3.1"
git tag t0.3.1
git push origin t0.3.1
You will know it worked if Test PyPI has updated the version number
Note: Do not use the
v
tag to test the PR because that will cause a new release which is not ideal.At the same time you should see the release number go up. This is why you should do it in your own fork.
Linked Issues
Closes: #137
Type of Change
Contributors