Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with upcoming ggplot2 3.5.0 #28

Open
teunbrand opened this issue Feb 7, 2024 · 2 comments
Open

Potential issue with upcoming ggplot2 3.5.0 #28

teunbrand opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
minor issue Potential minor issue

Comments

@teunbrand
Copy link

Hi there,

We have been preparing for a new release of ggplot2, and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break genekitr.

The issue we encountered is in the plotVenn() function, but we believe the cause of the issue is krassowski/complex-upset#192.

I think no action is required from genekitr's side, but this issue is a heads up that plotVenn() might become broken through no fault of your own.

@teunbrand teunbrand added the shiny-bug Shiny-server issue label Feb 7, 2024
@teunbrand teunbrand changed the title [shiny-bug] Potential issue with upcoming ggplot2 3.5.0 Feb 7, 2024
@teunbrand
Copy link
Author

I apologise for the incorrect label assigned to the issue.

@reedliu
Copy link
Contributor

reedliu commented Feb 7, 2024

Hi Teun,
Thank you for bringing this to our attention. We appreciate the heads-up regarding the potential issue with the plotVenn() function in relation to the upcoming ggplot2 3.5.0 release. We will keep an eye on this and take necessary actions if needed.

@reedliu reedliu added minor issue Potential minor issue and removed shiny-bug Shiny-server issue labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor issue Potential minor issue
Projects
None yet
Development

No branches or pull requests

2 participants