Small RenderMan Renderer updates #6288
Open
+99
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CreateRenderTarget()` returns an invalid id if not given any outputs, and `CreateRenderView()` does the same if given an invalid render target. And attempting to render with an invalid view is a hard crash in RenderMan. So we catch this case and emit a warning instead.
These match the defaults defined in `startup/GafferScene/renderManOptions.py`. Our usual mantra is "expose the renderer directly", in which case we shouldn't be trying to provide defaults at all. But in this case I think it's the lesser of the evils : - If we don't define a default, it's a real faff to set up denoising, because all the documentation for it says to use `U6`, which isn't defined by default. - Likewise the documented LPEs for separate diffuse and subsurface etc rely on these default definitions. - If we don't define a default, then the defaults come from `rendermn.ini`, which as installed defines U2 but nothing else. If we allow `rendermn.ini` to be in charge, then it would be really hard to show the defaults (we'd have to parse all the `.ini` files manually to figure it out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a crash rendering without outputs, and default lpe lobe definitions to match the ones advertised in the RenderManOptions node.