Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the compute_kid() #38

Open
chacorp opened this issue Sep 7, 2022 · 1 comment
Open

Typo in the compute_kid() #38

chacorp opened this issue Sep 7, 2022 · 1 comment

Comments

@chacorp
Copy link

chacorp commented Sep 7, 2022

for the Line 391 and 396 in compute_kid(), I think the 'None' should actually be 'feat_model'

np_feats1 = get_folder_features(fdir1, None, num_workers=num_workers,

@GaParmar
Copy link
Owner

GaParmar commented Sep 7, 2022

Hi,

Thank you for pointing this out!
This bug was introduced in v0.1.29.
Earlier versions (eg 0.1.28) should not have this issue.
I have addressed in the newest version 0.1.30 I just pushed.

-Gaurav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants