Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Persistence Matrix] Replace use of -1 as a dummy value with a proper method to avoid magic numbers #1152

Open
hschreiber opened this issue Nov 7, 2024 · 0 comments
Open

[Persistence Matrix] Replace use of -1 as a dummy value with a proper method to avoid magic numbers #1152

hschreiber opened this issue Nov 7, 2024 · 0 comments

Comments

@hschreiber
Copy link
Collaborator

hschreiber commented Nov 7, 2024 •
edited
Loading 

          I didn't notice it on the first PR of matrix, but I am not a big fan of magic numbers.
          I think it would help reading and finding in the code if we would have somewhere in matrix code a `static const Index magic_value{-1};` (with a proper name).
          If you are ok, you can also open an issue and fix it on another PR.

Originally posted by @VincentRouvreau in #1150 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hschreiber