Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using einshape to simplify our code. #1957

Open
jesnie opened this issue Aug 12, 2022 · 0 comments
Open

Consider using einshape to simplify our code. #1957

jesnie opened this issue Aug 12, 2022 · 0 comments

Comments

@jesnie
Copy link
Member

jesnie commented Aug 12, 2022

DeepMind has this library: https://github.com/deepmind/einshape
Maybe this could replace some of our leading_reshape etc.
I know this is similar to einops, but einops don't seem to work for TensorFlow, see: arogozhnikov/einops#187

Before using this we should double-check that it works for dynamically shaped tensors - maybe see the issue above for a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant