Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable builds for Houdini 20.5 #733

Conversation

mehmetoguzderin
Copy link
Contributor

No description provided.

@ShinFujieda ShinFujieda self-requested a review August 29, 2024 01:41
@ShinFujieda
Copy link
Collaborator

I noticed the environment light (dome light with texture) is not shown in the viewport.

Houdini VK:
image

RPR:
image

@ShinFujieda ShinFujieda linked an issue Sep 11, 2024 that may be closed by this pull request
@mehmetoguzderin
Copy link
Contributor Author

@ShinFujieda -san,

Thank you very much for the information in detail. I made a commit which avoids 1.0 depth when alpha is 0.0 and uses 0.99 (distinguishable even with 8-bit unsigned or 8-bit signed framebuffer). Does this help?

Screenshot for reference:

Screenshot 2024-10-23 at 20 21 26

@mehmetoguzderin
Copy link
Contributor Author

@ShinFujieda -san,

Thank you for the review! If I set dstHi to 0.99f, all the grid and gizmos disappear. Is it better to keep as 1.0 or still update?

@ShinFujieda
Copy link
Collaborator

I see. then I don't know how it's treated, but maybe the 1.0 value is reserved for such special components.
Then, let's keep it as 1.0 for now.

@ShinFujieda ShinFujieda merged commit 4afe212 into GPUOpen-LibrariesAndSDKs:master Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows or potentially all platforms] Houdini 20.5 build is broken
2 participants