Fix crash on macOS when using RPR Material Library and simplify its installation #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstallation The exact reason of the crash is not clear to me. I localized it to the usage of HTML in QMessageBox that displayed installation steps. So to minimize HTML usage here I reworked the installation process a bit.
hshakula
added a commit
to hshakula/RadeonProRenderUSD
that referenced
this pull request
May 27, 2021
…nstallation (GPUOpen-LibrariesAndSDKs#464) PURPOSE Resolve GPUOpen-LibrariesAndSDKs#453 EFFECT OF CHANGE Fixed crash on macOS on first use of the RPR Material Library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PURPOSE
Resolve #453
EFFECT OF CHANGE
Fixed crash on macOS on first use of the RPR Material Library.
NOTES FOR REVIEWERS
The exact reason of the crash is not clear to me. I localized it to the usage of HTML in QMessageBox that displayed installation steps.
So to minimize HTML usage here I reworked the installation process a bit.