Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shading is flat; normals aren't interpolated #435

Closed
trebconnell opened this issue Jan 22, 2021 · 5 comments
Closed

Shading is flat; normals aren't interpolated #435

trebconnell opened this issue Jan 22, 2021 · 5 comments

Comments

@trebconnell
Copy link
Contributor

This image taken from Usd kitchen_set scene, Quality: Northstar, but also reproduces using 'Medium' quality

Platform: Windows
RprUsd Ver: 2.0.19 (f9d793d)
Usd Ver: v20.11

image

@hshakula
Copy link
Contributor

With RPR delegate it was preferable to explicitly control the level of subdivision. But that was back in the days. Now we can try to roll out automatic subdivision. I will implement it.

Low-High qualities do not support subdivision for now.

@trebconnell
Copy link
Contributor Author

Thanks, but I believe this should be able to be fixed by using a different shading model which interpolates normals across the face. Ex: https://en.m.wikipedia.org/wiki/Shading

@hshakula
Copy link
Contributor

@trebconnell, please have a look at the images from #436

@trebconnell
Copy link
Contributor Author

trebconnell commented Jan 22, 2021

Thanks! Those look great. Thanks for fast turn around here!
Edit: Read PR, ah yeah makes sense this could also be caused by normals not being smoothed.

@hshakula
Copy link
Contributor

hshakula commented Jan 22, 2021

The ability to subdiv will also be useful.

We have subdivision feature available with "Full" and "Full (Legacy)" qualities. You just need to create rpr:subdivisionLevel int primvar on a mesh. See example - subdivisionSample.zip

Let me know if you require subdivision in Low-High qualities.

@bsavery bsavery closed this as completed Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants