diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 0e18db517..6f28d773e 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -35,7 +35,7 @@ jobs: CMAKE_PREFIX_PATH: '/usr/lib/x86_64-linux-gnu/cmake/Qt6' SCRIPT: './tools/build_and_test_cmake.sh' TOOLS: 'clang' - - IMAGE: 'jammy' + - IMAGE: 'noble' CMAKE_PREFIX_PATH: '/usr/lib/x86_64-linux-gnu/cmake/Qt6' SCRIPT: './tools/build_extra_tests.sh' container: diff --git a/geo.cc b/geo.cc index 3f084bc2c..95e76ac9f 100644 --- a/geo.cc +++ b/geo.cc @@ -22,9 +22,9 @@ #include // for QByteArray #include // for QIODevice #include // for QString, operator==, QStringView::to... +#include // for qMakeStringPrivate, QStringLiteral #include // for QStringView #include // for QXmlStreamAttributes -#include // for qPrintable, QIODeviceBase::ReadOnly #include "defs.h" #include "geocache.h" // for Geocache, Geocache::container_t, Geo... diff --git a/geo.h b/geo.h index 8267cfc4c..3b86c6a91 100644 --- a/geo.h +++ b/geo.h @@ -19,6 +19,7 @@ #ifndef GEO_H_INCLUDED_ #define GEO_H_INCLUDED_ +#include // for QList #include // for QString #include // for QVector #include // for QXmlStreamReader diff --git a/googletakeout.cc b/googletakeout.cc index b00e86f28..57fa02f21 100644 --- a/googletakeout.cc +++ b/googletakeout.cc @@ -27,14 +27,12 @@ #include // for QDebug #include // for QDir #include // for QFileInfo -#include // for QFileInfoList #include // for operator|, QIODevice #include // for QJsonArray, QJsonArray::const_iterator #include // for QJsonDocument #include // for QJsonObject, QJsonObject::const_iterator #include // for QJsonParseError, QJsonParseError::NoError -#include // for QJsonValueRef -#include // for ISODate, QIODeviceBase::ReadOnly, QIODeviceBase::Text +#include #include "src/core/datetime.h" // for DateTime #include "src/core/file.h" // for File diff --git a/mtk_logger.cc b/mtk_logger.cc index 5db9163ca..c9704cd61 100644 --- a/mtk_logger.cc +++ b/mtk_logger.cc @@ -54,33 +54,34 @@ #include "mtk_logger.h" -#include // for clamp -#include // for isdigit -#include // for va_end, va_start -#include // for memcmp, memset, strncmp, strlen, memmove, strchr, strcpy, strerror, strstr +#include // for clamp +#include // for isdigit +#include // for errno +#include // for fabs +#include // for va_end, va_start +#include // for memcmp, memset, strncmp, strlen, memmove, strchr, strcpy, strerror, strstr +#include // for strtoul #if __WIN32__ -#include // for _chsize +#include // for _chsize #else -#include // for ftruncate +#include // for ftruncate #endif -#include // for QByteArray -#include // for QChar -#include // for QDateTime -#include // for QDir -#include // for QFile -#include // for QLatin1Char -#include // for qMakeStringPrivate, QStringLiteral -#include // for QThread -#include // for qPrintable, UTC -#include // for errno -#include // for fabs -#include // for strtoul +#include // for QByteArray +#include // for QChar +#include // for QDateTime +#include // for QDir +#include // for QFile +#include // for QLatin1Char +#include // for QtMsgType +#include // for qMakeStringPrivate, QStringLiteral +#include // for QThread +#include // for qPrintable #include "defs.h" -#include "gbfile.h" // for gbfprintf, gbfputc, gbfputs, gbfclose, gbfopen, gbfile -#include "gbser.h" // for gbser_read_line, gbser_set_port, gbser_OK, gbser_deinit, gbser_init, gbser_print, gbser_TIMEOUT -#include "src/core/datetime.h" // for DateTime +#include "gbfile.h" // for gbfprintf, gbfputc, gbfputs, gbfclose, gbfopen, gbfile +#include "gbser.h" // for gbser_read_line, gbser_set_port, gbser_OK, gbser_deinit, gbser_init, gbser_print, gbser_TIMEOUT +#include "src/core/datetime.h" // for DateTime #define MTK_EVT_BITMASK (1<<0x02) diff --git a/mtk_logger.h b/mtk_logger.h index 662e4606e..73d9e51d7 100644 --- a/mtk_logger.h +++ b/mtk_logger.h @@ -57,6 +57,7 @@ #include // for FILE #include // for time_t +#include // for QList #include // for QString #include // for QVector diff --git a/tools/Dockerfile_noble b/tools/Dockerfile_noble index ac01c7e92..af4179770 100644 --- a/tools/Dockerfile_noble +++ b/tools/Dockerfile_noble @@ -7,9 +7,15 @@ LABEL maintainer="https://github.com/tsteven4" WORKDIR /app # update environment. +# software-properties-common, gpg-agent and ppa:tsteven4/clazy-backports +# are needed to get a backported version of clazy (1.12-2~noble12) that works +# with Qt6. ARG DEBIAN_FRONTEND=noninteractive RUN apt-get update && apt-get install -y --no-install-recommends \ apt-utils \ + software-properties-common \ + gpg-agent \ + && add-apt-repository ppa:tsteven4/clazy-backports \ && apt-get upgrade -y \ && rm -rf /var/lib/apt/lists/* diff --git a/tools/make_docker_image b/tools/make_docker_image index 437722b00..cc8aa4c74 100755 --- a/tools/make_docker_image +++ b/tools/make_docker_image @@ -7,9 +7,11 @@ TMPDIR=$(mktemp -d) cp Dockerfile${versuffix} $TMPDIR -docker build --pull --file Dockerfile${versuffix} \ +docker buildx build \ + --pull --file Dockerfile${versuffix} \ --tag tsteven4/gpsbabel_build_environment${versuffix}:latest \ --tag tsteven4/gpsbabel_build_environment${versuffix}:$tag \ + --progress=plain \ $TMPDIR /bin/rm -fr $TMPDIR docker push tsteven4/gpsbabel_build_environment${versuffix}:$tag diff --git a/unicsv.cc b/unicsv.cc index 34b557ef7..a9d71b0e2 100644 --- a/unicsv.cc +++ b/unicsv.cc @@ -404,7 +404,7 @@ UnicsvFormat::unicsv_fondle_header(QString header) } } - for (auto value : values) { + for (auto value : std::as_const(values)) { value = value.trimmed(); unicsv_fields_tab.append(fld_terminator); // default diff --git a/v900.cc b/v900.cc index bcc248aa7..c961fe316 100644 --- a/v900.cc +++ b/v900.cc @@ -73,16 +73,16 @@ for a little more info, see structures: #include "v900.h" -#include // for assert -#include // for va_end, va_start -#include // for fclose, fgets, fread, va_list -#include // for strtod -#include // for strncmp, strcat, strcpy, strstr - -#include // for QByteArray -#include // for QDate -#include // for QTime -#include // for qPrintable, UTC +#include // for assert +#include // for va_end, va_start +#include // for fclose, fgets, fread, va_list +#include // for strtod +#include // for strncmp, strcat, strcpy, strstr + +#include // for QByteArray +#include // for QDate +#include // for QtMsgType +#include // for QTime #include "defs.h" diff --git a/v900.h b/v900.h index 5a2b578f7..8501eb9dc 100644 --- a/v900.h +++ b/v900.h @@ -27,6 +27,7 @@ #include // for FILE #include // for QDateTime +#include // for QList #include // for QString #include // for QVector diff --git a/vecs.cc b/vecs.cc index 1617d02a6..f13c026f6 100644 --- a/vecs.cc +++ b/vecs.cc @@ -767,7 +767,7 @@ QVector Vecs::create_style_vec() dir.setNameFilters(QStringList("*.style")); dir.setFilter(QDir::Files); dir.setSorting(QDir::Name); - QFileInfoList fileinfolist = dir.entryInfoList(); + const QFileInfoList fileinfolist = dir.entryInfoList(); QVector slist; for (const auto& fileinfo : fileinfolist) { if (!fileinfo.isReadable()) {