Autogenerate about dialog stuff from AUTHORS and DOCUMENTORS.

2003-07-28  Colin Walters  <[email protected]>

	* AUTHORS:
	* DOCUMENTERS:
	* HACKING:
	* INTERNALS:
	* Makefile.am:
	* shell/Makefile.am:
	* shell/rb-shell.c: (rb_shell_cmd_about),
	(rb_shell_cmd_new_station):

	Autogenerate about dialog stuff from AUTHORS and DOCUMENTORS.

	Make "New Internet Radio Station" menu entry work.

	Minor updates to HACKING and INTERNALS.

Author: cgwalters

AUTHORS

@@ -1,6 +1,16 @@
 Jorn Baayen <[email protected]>
-Marco Pesenti Gritti <[email protected]>
-Bastien Nocera <[email protected]>
-Seth Nickell <[email protected]>
-Olivier Martin <[email protected]>
 Colin Walters <[email protected]>
+Bastien Nocera <[email protected]>
+Marco Pesenti Gritti <[email protected]>
+Kenneth Christiansen <[email protected]>
+Mark Finlay <[email protected]>
+Mark Humphreys <[email protected]>
+Laurens Krol <[email protected]>
+Xan Lopez <[email protected]>
+Olivier Martin <[email protected]>
+Seth Nickell <[email protected]>
+Jan Arne Petersen <[email protected]>
+Kristian Rietveld <[email protected]>
+Christian Schaller <[email protected]>
+Dennis Smit <[email protected]>
+James Willcox <[email protected]>

ChangeLog

@@ -1,3 +1,20 @@
+2003-07-28  Colin Walters  <[email protected]>
+
+	* AUTHORS:
+	* DOCUMENTERS:
+	* HACKING:
+	* INTERNALS:
+	* Makefile.am:
+	* shell/Makefile.am:
+	* shell/rb-shell.c: (rb_shell_cmd_about),
+	(rb_shell_cmd_new_station):
+
+	Autogenerate about dialog stuff from AUTHORS and DOCUMENTORS.
+
+	Make "New Internet Radio Station" menu entry work.
+
+	Minor updates to HACKING and INTERNALS.
+
 2003-07-28  Colin Walters  <[email protected]>
 
 	* configure.in: Don't use -Werror by default, for now.

DOCUMENTERS

@@ -0,0 +1,3 @@
+Luca Ferretti <[email protected]>
+Mark Finlay <[email protected]>
+Mark Humphreys <[email protected]>

HACKING

@@ -2,7 +2,22 @@ In order to keep the code nice and clean we have a few requirements you'll
 need to stick to in order to get your patch accepted:
 
 - use 8-space tabs for indentation
-- curly brackets are NOT on a new line (we are slowly converting the code)
+- curly brackets are NOT on a new line, except for function definitions.
+  (we are slowly converting the code)
+
+  Here is a correctly indented sample:
+
+void
+foo (const char *bla, gpointer cow)
+{
+	if (!strcmp (bla, cow)) {
+		g_print ("moo!");
+		return;
+	}
+
+	...
+}	
+
 - if statements are written like this: "if (this != that)"
 - g_list_next/previous is preferred to list->next or list->previous
 - every function should have a prototype

INTERNALS

@@ -61,7 +61,7 @@ The Library is the main part of Rhythmbox; it is the thing that lets
 you play local files.  We'll go over some of the most important things,
 and then come back to it later once we know more.
 
-*** RBNode, RBNodeSong
+*** RBNode
 
 Understanding RBNode (library/rb-node.c) is crucial.  RBNode is not
 just used by the Library actually; every other source uses it as well.
@@ -74,11 +74,6 @@ types; e.g. a string, integer, or a pointer to another node.
 These dynamic properties pretty much correspond to the song
 metadata you can see like song length, duration, location, etc.
 
-However, the songs are not represented directly by RBNode instances.
-Instead, the library has a subclass of RBNode called RBNodeSong.  This
-is subclass just is a bit more convenient to work with for the library
-than RBNode directly.
-
 **** The tree structure
 So where does the parent/children relationship come in?
 Rhythmbox maintains a sort of database of your music.  This is what

Makefile.am

@@ -17,4 +17,3 @@ CLEANFILES =				\
 	./intltool-extract 		\
 	./intltool-merge 		\
 	./intltool-update
-

shell/Makefile.am

@@ -1,3 +1,18 @@
+
+AUTHORS.tab : $(top_srcdir)/AUTHORS
+	cat $(top_srcdir)/AUTHORS | sed -e 's/^/"/' -e 's/$$/",/' > $@.tmp
+	mv $@.tmp $@
+
+MAINTAINERS.tab : $(top_srcdir)/MAINTAINERS
+	cat $(top_srcdir)/MAINTAINERS | sed -e 's/^/"/' -e 's/$$/",/' > $@.tmp
+	mv $@.tmp $@
+
+DOCUMENTERS.tab : $(top_srcdir)/DOCUMENTERS
+	cat $(top_srcdir)/DOCUMENTERS | sed -e 's/^/"/' -e 's/$$/",/' > $@.tmp
+	mv $@.tmp $@
+
+tab_files = AUTHORS.tab MAINTAINERS.tab DOCUMENTERS.tab
+
 bin_PROGRAMS = rhythmbox 
 
 rhythmbox_interface_idl_sources =      		\
@@ -55,12 +70,16 @@ INCLUDES = 						\
 
 CLEAN_FILES = $(rhythmbox_interface_idl_sources)
 
-Rhythmbox-common.c Rhythmbox-stubs.c Rhythmbox-skels.c Rhythmbox.h: Rhythmbox.idl
+$(rhythmbox_interface_idl_sources): Rhythmbox.idl
 	$(ORBIT_IDL) -I $(LIBBONOBO_IDL) -I $(BONOBO_ACTIVATION_IDL) $(srcdir)/Rhythmbox.idl
 
+BUILT_SOURCES = $(rhythmbox_interface_idl_sources) $(tab_files)
+
 EXTRA_DIST = Rhythmbox.idl
 
 CLEANFILES =			\
+	AUTHORS.tab		\
+	MAINTAINERS.tab		\
 	Rhythmbox-common.c	\
 	Rhythmbox-stubs.c	\
 	Rhythmbox-skels.c	\

shell/rb-shell.c

@@ -151,9 +151,9 @@ static void rb_shell_cmd_load_playlist (BonoboUIComponent *component,
 static void rb_shell_cmd_new_playlist (BonoboUIComponent *component,
 				       RBShell *shell,
 				       const char *verbname);
-/* static void rb_shell_cmd_new_station (BonoboUIComponent *component, */
-/* 				      RBShell *shell, */
-/* 				      const char *verbname); */
+static void rb_shell_cmd_new_station (BonoboUIComponent *component,
+				      RBShell *shell,
+				      const char *verbname);
 static void rb_shell_cmd_delete_group (BonoboUIComponent *component,
 				       RBShell *shell,
 				       const char *verbname);
@@ -289,7 +289,7 @@ static BonoboUIVerb rb_shell_verbs[] =
 	BONOBO_UI_VERB ("AddLocation",  (BonoboUIVerbFn) rb_shell_cmd_add_location),
 	BONOBO_UI_VERB ("LoadPlaylist", (BonoboUIVerbFn) rb_shell_cmd_load_playlist),
  	BONOBO_UI_VERB ("NewPlaylist",  (BonoboUIVerbFn) rb_shell_cmd_new_playlist),
-/* 	BONOBO_UI_VERB ("NewStation",   (BonoboUIVerbFn) rb_shell_cmd_new_station), */
+	BONOBO_UI_VERB ("NewStation",   (BonoboUIVerbFn) rb_shell_cmd_new_station),
 	BONOBO_UI_VERB ("RenamePlaylist",(BonoboUIVerbFn) rb_shell_cmd_rename_group),
 	BONOBO_UI_VERB ("DeletePlaylist",(BonoboUIVerbFn) rb_shell_cmd_delete_group),
 	BONOBO_UI_VERB_END
@@ -1073,38 +1073,23 @@ rb_shell_cmd_about (BonoboUIComponent *component,
 		    RBShell *shell,
 		    const char *verbname)
 {
+	const char **tem;
 	static GtkWidget *about = NULL;
 	GdkPixbuf *pixbuf = NULL;
 
 	const char *authors[] =
 	{
 		"",
-		"Jorn Baayen ([email protected])",
-		"Colin Walters ([email protected])",
+#include "MAINTAINERS.tab"
 		"",
-		"",
-		"Kenneth Christiansen ([email protected])",
-		"Mark Finlay ([email protected])",
-		"Marco Pesenti Gritti ([email protected])",
-		"Mark Humphreys ([email protected])",
-		"Laurens Krol ([email protected])",
-		"Xan Lopez ([email protected])",
-		"Olivier Martin ([email protected])",
-		"Seth Nickell ([email protected])",
-		"Bastien Nocera ([email protected])",
-		"Jan Arne Petersen ([email protected])",
-		"Kristian Rietveld ([email protected])",
-		"Christian Schaller ([email protected])",
-		"Dennis Smit ([email protected])",
-		"James Willcox ([email protected])",
+		NULL,
+#include "AUTHORS.tab"
 		NULL
 	};
 
 	const char *documenters[] =
 	{
-		"Luca Ferretti ([email protected])",
-		"Mark Finlay ([email protected])",
-		"Mark Humphreys ([email protected])",
+#include "DOCUMENTERS.tab"
 		NULL
 	};
 
@@ -1118,8 +1103,15 @@ rb_shell_cmd_about (BonoboUIComponent *component,
 
 	pixbuf = gdk_pixbuf_new_from_file (rb_file ("about-logo.png"), NULL);
 
-	authors[0] = _("Lead developers:");
-	authors[4] = _("Contributors:");
+	authors[0] = _("Maintainers:");
+	tem = authors;
+	while (1) {
+		if (*tem == NULL) {
+			*tem = _("Contributors:");
+			break;
+		}
+		tem++;
+	}
 
 	about = gnome_about_new ("Rhythmbox", VERSION,
 				 "Copyright \xc2\xa9 2002, 2003 Jorn Baayen, Colin Walters",
@@ -1449,18 +1441,17 @@ rb_shell_cmd_delete_group (BonoboUIComponent *component,
 }
 
 
-/* static void */
-/* rb_shell_cmd_new_station (BonoboUIComponent *component, */
-/* 			  RBShell *shell, */
-/* 			  const char *verbname) */
-/* { */
-/* 	GtkWidget *dialog; */
-/* 	rb_debug ("Got new station command"); */
-/* 	dialog = rb_new_station_dialog_new (shell->priv->iradio_backend); */
-/* 	gtk_dialog_run (GTK_DIALOG (dialog)); */
-/* 	gtk_widget_destroy (dialog); */
-/* } */
-
+static void
+rb_shell_cmd_new_station (BonoboUIComponent *component,
+			  RBShell *shell,
+			  const char *verbname)
+{
+	GtkWidget *dialog;
+	rb_debug ("Got new station command");
+	dialog = rb_new_station_dialog_new (shell->priv->iradio_backend);
+	gtk_dialog_run (GTK_DIALOG (dialog));
+	gtk_widget_destroy (dialog);
+}
 
 static void
 rb_shell_quit (RBShell *shell)