-
Notifications
You must be signed in to change notification settings - Fork 1
Description
ArmadaSparkE2E.scala, scripts/dev-e2e.sh, and conf/spark-defaults.conf assume the Armada server is always hosted on localhost, and runs the actual tests in a local Docker container.
The code should be adjusted so testing an armada-spark client that uses a remote Armada server host should be possible. The changes (so far) should be:
-
make the constructor in ArmadaSparkE2E pass the Armada server's hostname to the ArmadaClient constructor
-
scripts/dev-e2e.sh should use ARMADA_MASTER, etc for setting props passed
-
conf/spark-defaults.conf should have its
spark.armada.lookouturlconfigured dynamically -
the armada-operator repo should get a new (separate) kind-config.yaml that opens the Armada API and Lookout ports for external access
-
Also, the scripts/set-version.sh script fails if running on macOS and
sedis the Apple default version - the script should look forgsedand use that when running on macOS, otherwise use /usr/bin//sed.