Skip to content

Commit b3cb366

Browse files
authored
Merge pull request #91 from G-Research/SREWRK-1440-tracing-log-traceid
Add traceID to log entries were a trace span is available
2 parents 8136c56 + c2c2f21 commit b3cb366

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/store/store.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,11 @@ func (store *OpenTSDBStore) updateMetrics(ctx context.Context, logger log.Logger
144144
defer cancel()
145145
err := store.loadAllMetricNames(trace.NewContext(ctx, tr))
146146
if err != nil {
147-
level.Info(store.logger).Log("err", err)
147+
level.Info(store.logger).Log("err", err, "traceID", span.SpanContext().TraceID)
148148
events.Errorf("error: %v", err)
149149
} else {
150150
store.internalMetrics.lastUpdateOfOpenTSDBMetrics.Set(float64(time.Now().Unix()))
151-
level.Debug(logger).Log("msg", "metric names have been refreshed")
151+
level.Debug(logger).Log("msg", "metric names have been refreshed", "traceID", span.SpanContext().TraceID)
152152
events.Printf("Refreshed")
153153
}
154154
}
@@ -225,7 +225,7 @@ func (store *OpenTSDBStore) Series(
225225
}
226226
query, warnings, err := store.composeOpenTSDBQuery(req)
227227
if err != nil {
228-
level.Error(store.logger).Log("err", err)
228+
level.Error(store.logger).Log("err", err, "traceID", span.SpanContext().TraceID)
229229
return err
230230
}
231231
if len(query.Queries) == 0 {
@@ -252,7 +252,7 @@ func (store *OpenTSDBStore) Series(
252252
if code, ok := qerr["code"].(float64); ok && code == 400 {
253253
msg, ok := qerr["message"].(string)
254254
if !ok || !strings.Contains(msg, "No such name for ") {
255-
level.Info(store.logger).Log("msg", "Ignoring 400 error", "err", err)
255+
level.Info(store.logger).Log("msg", "Ignoring 400 error", "err", err, "traceID", span.SpanContext().TraceID)
256256
}
257257
// Ignore all 400 errors, regardless of the reason (but the logs
258258
// should say if it's not a non-existent metric).
@@ -290,7 +290,7 @@ func (store *OpenTSDBStore) Series(
290290
return nil
291291
})
292292
if err != nil {
293-
level.Error(store.logger).Log("err", err)
293+
level.Error(store.logger).Log("err", err, "traceID", span.SpanContext().TraceID)
294294
return err
295295
}
296296
return nil
@@ -369,7 +369,7 @@ func (store *OpenTSDBStore) LabelValues(
369369
ctx, span = tracer.Start(ctx, "OpenTSDBStore.LabelValues")
370370
defer span.End()
371371

372-
level.Debug(store.logger).Log("msg", "LabelValues", "Label", req.Label)
372+
level.Debug(store.logger).Log("msg", "LabelValues", "Label", req.Label, "traceID", span.SpanContext().TraceID)
373373
if req.Label == "__name__" {
374374
if !store.enableMetricSuggestions {
375375
// An error for this breaks Thanos query UI; return an empty list instead.

0 commit comments

Comments
 (0)