Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notindexeringssystem #33

Open
oskarr opened this issue Apr 16, 2022 · 1 comment
Open

Notindexeringssystem #33

oskarr opened this issue Apr 16, 2022 · 1 comment
Labels
cleanup Improvements to readability or maintainability. consideration This issue has an unclear code complexity/maintenance to user demand tradeoff. enhancement New feature or request stability This problem may cause bugs in the future, but has no apparent consequences right now.

Comments

@oskarr
Copy link
Member

oskarr commented Apr 16, 2022 •
edited
Loading

Just nu indexeras noter genom att noternas filnamn börjar med samma index som låtens index. Problemet med detta är att t.ex. ζ1 får noterna till ζ11, eftersom det inte finns någon not för ζ1. Inte bra.
@oskarr oskarr added the bug Something isn't working label Apr 16, 2022
oskarr added a commit that referenced this issue Apr 17, 2022
@oskarr
Quick-fix for #33
6ce8a01
@oskarr oskarr mentioned this issue Apr 17, 2022
Merged
@oskarr oskarr added enhancement New feature or request cleanup Improvements to readability or maintainability. and removed bug Something isn't working labels Apr 17, 2022
@oskarr
Copy link
Member Author

oskarr commented Jul 18, 2022 •
edited
Loading

Problemet är quick-fixat sedan 6ce8a01 genom att kräva att indexet avslutas med en punkt.

Eventuellt bör det övervägas att bygga om notindexeringssystemet, så att varje låt får ett unikt id, som inte förändras, och inte innehåller specialtecken.

Edit: Vi bör även kontrollera att noter fungerar med sigma-index (och liknande), som har en punkt i namnet.

@oskarr oskarr added the consideration This issue has an unclear code complexity/maintenance to user demand tradeoff. label Jul 18, 2022
@oskarr oskarr added the stability This problem may cause bugs in the future, but has no apparent consequences right now. label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Improvements to readability or maintainability. consideration This issue has an unclear code complexity/maintenance to user demand tradeoff. enhancement New feature or request stability This problem may cause bugs in the future, but has no apparent consequences right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oskarr