Merge pull request #215 from theunkn0wn1/fix/SPARK-242

[SPARK-242] Fix errors when injecting with no additional data.

Author: theunkn0wn1

src/commands/case_management.py

@@ -370,7 +370,7 @@ async def cmd_case_management_inject(ctx: Context):
         logger.debug("creating rescue for {!r}", tokens.subject[0])
         rescue = await ctx.bot.board.create_rescue(client=tokens.subject[0])
         async with ctx.bot.board.modify_rescue(rescue, impersonation=ctx.user.account) as case:
-            case.add_quote(ctx.words_eol[2], ctx.user.nickname)
+            case.add_quote(ctx.words_eol[0], ctx.user.nickname)
 
             # check specific capture groups for existence.
             if tokens.xbox:
@@ -385,7 +385,7 @@ async def cmd_case_management_inject(ctx: Context):
                 case.code_red = True
 
             await ctx.reply(
-                f"{case.client}'s case opened with: " f"{ctx.words_eol[2]}  (Case {case.board_index})"
+                f"{case.client}'s case opened with: " f"{ctx.words_eol[0]}  (Case {case.board_index})"
             )
 
             if case.code_red:
@@ -394,7 +394,7 @@ async def cmd_case_management_inject(ctx: Context):
             return
 
     async with ctx.bot.board.modify_rescue(rescue, impersonation=ctx.user.account) as case:
-        case.add_quote(ctx.words_eol[2], ctx.user.nickname)
+        case.add_quote(ctx.words_eol[0], ctx.user.nickname)
 
     await ctx.reply(
         f"{case.client}'s case updated with: " f"'{ctx.words_eol[2]}' (Case {case.board_index})"

tests/regressions/test_case_management_regressions.py

@@ -50,3 +50,18 @@ async def test_spark_239(bot_fx, rescue_sop_fx, monkeypatch):
     await trigger(context)
 
     assert rescue_sop_fx.client not in bot_fx.board
+
+
+async def test_spark_242(bot_fx):
+    """
+    Verifies that `!inject {name}` returns an usage error instead of dying horribly.
+    """
+
+    pre_len = len(bot_fx.board)
+
+    ctx = await Context.from_message(bot_fx, "#fuelrats", "Some_ov", "!inject sinkhole")
+
+    await trigger(ctx=ctx)
+
+    assert "sinkhole" in bot_fx.board
+    assert len(bot_fx.board) == pre_len + 1