Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename U128.as_64 to try_as_u64 and deprecate the old function #6954

Open
SwayStar123 opened this issue Feb 24, 2025 · 9 comments
Open

Rename U128.as_64 to try_as_u64 and deprecate the old function #6954

SwayStar123 opened this issue Feb 24, 2025 · 9 comments
Labels
good first issue Good for newcomers lib: std Standard library may be rewarded ODHack12

Comments

@SwayStar123
Copy link
Contributor

The function name is inconsistent with other downcasts, it needs to be updated to try_as_u64, and the old function needs to be deprecated and then later removed.
@SwayStar123 SwayStar123 added good first issue Good for newcomers lib: std Standard library labels Feb 24, 2025
@SwayStar123 SwayStar123 mentioned this issue Feb 24, 2025
Merged
8 tasks
@anushkasomani

This comment was marked as spam.

Sign in to view
@anushkasomani

This comment was marked as spam.

Sign in to view
@SwayStar123
Copy link
Contributor Author

sway-lib-std/src/u128.sw

@FriendlyLifeguard
Copy link

Hello, could I work on this?

@bernardev254
Copy link

Hello, this serves my intentions to take on the task of renaming U128.as_64 to try_as_u64 and deprecating the old function. This change will align the function name with other downcasts, making our codebase more consistent and easier to understand.

I'll ensure that the deprecation process is handled smoothly, updating any internal usages and providing clear guidance for external users to transition to the new function.

@pheobeayo
Copy link

Let me handle this issue!

@saimeunt
Copy link

Following up on my work on #7042 and #7043, I'd like to continue fixing issues on Sway, please assign me.

@Zeegaths
Copy link

Could I take on this issue?

@Sundayabel222
Copy link

Can I start working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers lib: std Standard library may be rewarded ODHack12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@saimeunt @IGI-111 @SwayStar123 @pheobeayo @FriendlyLifeguard @bernardev254 @Zeegaths @anushkasomani @Sundayabel222