Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Expected an item" error when mixing doc-comments and other attributes #6917

Open
ironcev opened this issue Feb 11, 2025 · 0 comments
Open
Assignees
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged team:compiler Compiler Team

Comments

@ironcev
Copy link
Member

ironcev commented Feb 11, 2025

Doc-comments are attributes and can be arbitrarily mixed with other attributes. E.g., the following example should compile but it produces an "Expected an item" error:

/// This is the first line of the comment.
#[allow(dead_code)]
/// This is the second line.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Expected an item.
pub fn fun() {}

The resulting documentation string in forc doc and LSP must be the joint of all the doc comments.

@ironcev ironcev self-assigned this Feb 11, 2025
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser team:compiler Compiler Team labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged team:compiler Compiler Team
Projects
None yet
Development

No branches or pull requests

1 participant