Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create-fuels logic to not depend on process.env.VITEST #3770

Open
nedsalk opened this issue Mar 12, 2025 · 0 comments
Open

Refactor create-fuels logic to not depend on process.env.VITEST #3770

nedsalk opened this issue Mar 12, 2025 · 0 comments
Labels
chore Issue is a chore

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Mar 12, 2025

We are currently using process.env.VITEST in production code to govern whether checks for the existence of fuelup on the user's machine will be done. This environment variable is only defined in our tests. We should remove this in favor of something else, e.g. a flag like pnpm create fuels --skip-fuelup-check. If we were to switch to e.g. bun for testing, the create-fuels tests would fail because the VITEST environment variable isn't defined.

@nedsalk nedsalk added the chore Issue is a chore label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

1 participant