-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement signed-type data #3715
Comments
We can go on the route of changing the prefix text to |
Pros:
Cons:
I have gone with using |
As per a quick conversation I had with @luizstacio:
// all pseudo code to illustrate
signMessage('string' || bytes) // default/existent method
signMessage({ raw: .... }) // using EIP19 Could we also have an extra parameter, maybe? Not sure. We could also look at Viem, as they use a similar approach from which we could draw inspiration. |
Implemented the changes, one small comment questioning the |
This should allow applications to request the signature of any arbitrary bytecode, encoded using the schema provided by the DApp, then hashed and prefixed by fixed data. In the case of ETH,
Ethereum Signed Message:\n
.The text was updated successfully, but these errors were encountered: