-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction ID not correctly set on Contract input #3708
Comments
I believe this happens because we no longer fetch the transaction within Instead, we update specific parts of it using data from the subscription result.
|
Once this has been completed, we should enable the tests in #3710. |
@Torres-ssf found out the following:
Therefore we can't obtain the tx ID without a fetch, which defeats the point of the implementation proposed in #3764. |
This input can be set correctly using |
When we create a new contract input against a transaction, we always zero out the transaction ID.
fuels-ts/packages/account/src/providers/transaction-request/input.ts
Line 117 in 02503a6
This has not been a problem because this value is meant to be zeroed out for hashing/signing.
However when building out a transaction summary from a transaction response (
transactionResponse.getTransactionSummary()
) the summary is technically not correct as this input has not been populated correctly. Whereas a summary generated using a transaction ID (getTransactionSummary(txId)
) fetches the full tx from the node, has this input set correctly.The text was updated successfully, but these errors were encountered: