Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GraphQL subscriptions handling #3684

Open
arboleya opened this issue Feb 10, 2025 · 0 comments · Fixed by #3695
Open

Improve GraphQL subscriptions handling #3684

arboleya opened this issue Feb 10, 2025 · 0 comments · Fixed by #3695
Labels
chore Issue is a chore

Comments

@arboleya
Copy link
Member

It has been observed that sometimes subscriptions are left open.

We must ensure all subscriptions are closed to avoid bloating the nodes.

Quoting @Voxelot:

  • My assumption was that the node creates a buffer for each subscription that hangs around either until 1) it is fuly consumed or 2) a timeout occurs and the buffer is dropped.
    The subscription wouldn't automatically close immediately when the final state comes, because if it didn't wait for the sdk to consume the messages then the buffer would close before the user sees the messages. So if we have a lot of junk subscriptions hanging around, the problem is either with 1 or 2. Ie. there's something in the frontend opening subscriptions but ignoring the result and not consuming the messages or the client isn't properly closing the buffer when all the messages are read.

Follow-up after:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants