Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage traits to expose API for estimated number of items #1857

Closed
segfault-magnet opened this issue Apr 23, 2024 · 1 comment
Closed

Storage traits to expose API for estimated number of items #1857

segfault-magnet opened this issue Apr 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@segfault-magnet
Copy link
Contributor

Progress tracking for snapshot generation doesn't have a defined end since the iterator returned by rocksdb doesn't have a size hint nor is the query for the number of keys exposed.

Adapt the storage interfaces so that they can provide an estimate as to the number of items and use it to provide the snapshot exporting progress tracking logic with an upper limit.

@segfault-magnet segfault-magnet added the enhancement New feature or request label Apr 23, 2024
@xgreenx
Copy link
Collaborator

xgreenx commented Oct 3, 2024

For simplify of the codebase maybe let's not do that for now.

@xgreenx xgreenx closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants