Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: put default amount of keep_results into a variables file #47

Closed
Zeanon opened this issue Jan 15, 2024 · 5 comments · Fixed by #115
Closed

Idea: put default amount of keep_results into a variables file #47

Zeanon opened this issue Jan 15, 2024 · 5 comments · Fixed by #115
Labels
done Issue is done but not merged on main enhancement New feature or request

Comments

@Zeanon
Copy link
Contributor

Zeanon commented Jan 15, 2024

Describe the feature or hardware support you'd like

I think it would be nice, to be able to alter the default amount of keep_results without having to specify it in the command every time.
Solution would be rather easy, have one variable file, that gets copied instead of symlinked and the install script checks whether it already exists (if not, it gets copied, if it exists, it wont)
(I can do a pr for it, just wanted to check whether you would even consider it first)

Additional context or information

No response

@Zeanon Zeanon added the enhancement New feature or request label Jan 15, 2024
@Frix-x
Copy link
Owner

Frix-x commented Jan 15, 2024

Hi, thanks for the suggestion, and yes this is something already in my backlog. It was just not the priority but I definitely want to add this.

I'm really open for a PR if you want to work on this :)
Also, at the same time I wanted to have the accelerometer chip name and the "keep_csv" in this variable in the same way. And maybe define a main read-only file as a simlink with default value that one could copy paste and override in his config if needed. What do you think about this? It would make it easier for updates and avoid potential breaking changes.

@Zeanon
Copy link
Contributor Author

Zeanon commented Jan 15, 2024

Hi, thanks for the suggestion, and yes this is something already in my backlog. It was just not the priority but I definitely want to add this.

I'm really open for a PR if you want to work on this :) Also, at the same time I wanted to have the accelerometer chip name and the "keep_csv" in this variable in the same way. And maybe define a main read-only file as a simlink with default value that one could copy paste and override in his config if needed. What do you think about this? It would make it easier for updates and avoid potential breaking changes.

Sounds good, havent thought about those two as well but makes sense to also make them "static"
I would also add a version variable to it which gets checked on startup, to prevent mishaps (like I am doing here: https://github.com/LynxCrew/Klicky/blob/main/Variables/homing_variables.cfg)
I'll get to it later and write the code for it

@Zeanon
Copy link
Contributor Author

Zeanon commented Jan 15, 2024

PR is out

@Surion79
Copy link

could you please link your PR to the issue or vice versa? Thanks :)

@Frix-x
Copy link
Owner

Frix-x commented Feb 14, 2024

@Surion79 #48

@Frix-x Frix-x added the done Issue is done but not merged on main label May 19, 2024
@Frix-x Frix-x linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issue is done but not merged on main enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants