Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Better log messages for failed web scrapping #6458

Open
math-GH opened this issue May 14, 2024 · 3 comments
Open

[Feature] Better log messages for failed web scrapping #6458

math-GH opened this issue May 14, 2024 · 3 comments
Labels
Feature Request ideas for new features
Milestone

Comments

@math-GH
Copy link
Contributor

math-GH commented May 14, 2024

If the web scrapping fails it writes an error log message.

But it does not help very much because the message has not useful information

grafik

I wished that here are more hints/information what could be wrong f.e. is there an issue with entering the website? is there an issue with finding the items? etc.

@math-GH math-GH added the Feature Request ideas for new features label May 14, 2024
@math-GH math-GH added this to the 1.25.0 milestone May 14, 2024
@math-GH
Copy link
Contributor Author

math-GH commented May 14, 2024

Is it a problem that the <doctype> is not in the first line of HTML?

grafik
(github.com website)

@Frenzie
Copy link
Member

Frenzie commented May 14, 2024

It shouldn't be.

@Alkarex
Copy link
Member

Alkarex commented May 14, 2024

Is it a problem that the <doctype> is not in the first line of HTML?

We are trimming leading white-space (while preserving BOM) to avoid such problems

$body = trim($body, " \n\r\t\v"); // Do not trim \x00 to avoid breaking a BOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request ideas for new features
Projects
None yet
Development

No branches or pull requests

3 participants