Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch_Schedule Objects column should work with labels instead of internal names #13787

Open
2 tasks done
furgo16 opened this issue May 2, 2024 · 4 comments
Open
2 tasks done
Labels
Feature FR for improvements or new features WB BIM Related to the BIM/Arch Workbench

Comments

@furgo16
Copy link
Contributor

furgo16 commented May 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

On the Arch_Schedule command, the "Objects" column works with internal names of objects only. For better usability, it should work with labels instead (or in addition to).

Full version info

OS: Ubuntu Core 22 (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37085 (Git) Snap 1005
Build type: Release
Branch: main
Hash: c7c07f28c639e82a6d2c58f4aaef5b42cddcc83c
Python 3.10.12, Qt 5.15.10, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.1
Installed mods: 
  * OpenTheme 2024.4.20
  * BIM 2021.12.0
  * Curves 0.6.35
  * ezydxf
  * ExplodedAssembly
  * BillOfMaterials 0.0.8.2
  * Ondsel-Lens 2024.4.16.01
  * Assembly4 0.50.12

Subproject(s) affected?

Arch

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added WB BIM Related to the BIM/Arch Workbench Feature FR for improvements or new features labels May 2, 2024
@Roy-043
Copy link
Contributor

Roy-043 commented May 2, 2024

Labels need not be unique which makes implementing this a little more complex than you may think.

@yorikvanhavre
Copy link
Member

Note that it's already possible to do that with filters. You leave the Name column blank (all objects), and you add a filter such as Label:MyName

Maybe actually we should remove the "Name" column. And have a kind of "filter editor" dialog to help people to create complex filters

@furgo16
Copy link
Contributor Author

furgo16 commented May 3, 2024

Thank you. I added a note with that workaround at https://wiki.freecad.org/Arch_Schedule.

Maybe actually we should remove the "Name" column. And have a kind of "filter editor" dialog to help people to create complex filters

Regarding removing the "Objects" column (I believe that's what you meant), I think it's still useful to have it, as it allows quickly selecting an object and adding it there with "Add selection". Unless the "filter editor" idea would provide an easy way to replicate this functionality (i.e. "Add selection" would by default add "Label:MyName").

Labels need not be unique which makes implementing this a little more complex than you may think.

I had not thought of that, good point. However, after having tried the setting of not requiring unique names, the amount of things that broke in different places (sorry for the vague statement, as I did not manage to file issues for all) made me go back to unique labels. That is, I feel other things would break earlier before breaking Arch_Schedule :-)

@yorikvanhavre
Copy link
Member

Also when using the filters, the selection is very greedy (it matches part of names too). So in that case, the possibility to have several objects with a same label is not really a problem. Same for the Objects column, the only result would be that there are several objects selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features WB BIM Related to the BIM/Arch Workbench
Projects
None yet
Development

No branches or pull requests

4 participants