[Problem] PR introduction text is being ignored #10195
Replies: 9 comments
-
Please add a legit title to this ticket l, TIA |
Beta Was this translation helpful? Give feedback.
-
Oops! Tks! |
Beta Was this translation helpful? Give feedback.
-
why create a separate issue for this and not jsut add this as comment in that issue? |
Beta Was this translation helpful? Give feedback.
-
Because this report is addresses the fact that lots of PRs are ignoring the introduction, and attempting to identify the cause and a possible solution, not just expressing a thought. |
Beta Was this translation helpful? Give feedback.
-
This should be a forum discussion and not an issue on GitHub. @berniev, please start a new thread on the forum with proposal of a new text/solution. |
Beta Was this translation helpful? Give feedback.
-
No, the policy of flicking issues back to forum was abandoned months ago. |
Beta Was this translation helpful? Give feedback.
-
I'm trying to convert this issue to a discussion and there is a problem. We need to do it manually. |
Beta Was this translation helpful? Give feedback.
-
The text is pretty low-value. Looking closer:
It's nice that we're appreciative but people probably don't actually feel thanked by reading this. It's boilerplate and can be removed.
Checking this doesn't actually 'do' anything. If it is checked, it doesn't mean the PR actually satisfies requirements and if it isn't checked it does't mean it doesn't. IMHO, This could be replaced with a link to the CONTRIBUTING.md file and a warning that improperly submitted PRs may be cancelled or delayed.
It seems premature to tell the contributor to update the wiki at this time. It would be better if the information could be emailed to them when the PR is merged. |
Beta Was this translation helpful? Give feedback.
-
since the text has been removed I think we can close this |
Beta Was this translation helpful? Give feedback.
-
Is there an existing issue for this?
Version
0.20 (Release)
Full version info
Subproject(s) affected?
None
Problem description
Further to #8657 the current structure of PR introduction is being ignored or deleted in many cases, including by senior members of this project.
The checkmark (place an 'x' to make a tick [huh?]) is counterintuitive and doesn't work if a leading or trailing space. An interesting UI design failure.
And who's going to read all that text, except maybe a first-timer. Maybe.
With no reward for jumping through these hoops and no punishment for not jumping through them, it is only natural they will be ignored, and possibly resented as cognitive distractions.
IMHO the whole text should be reduced to a couple of succinct, polite, lines and a couple of links.
Anything else?
No response
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions