Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snap edge/beta to OCC 7.7.2 #69

Open
luzpaz opened this issue Nov 8, 2022 · 14 comments
Open

Update snap edge/beta to OCC 7.7.2 #69

luzpaz opened this issue Nov 8, 2022 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@luzpaz
Copy link
Collaborator

luzpaz commented Nov 8, 2022

Per wwmayer OCC 7.7.0 compiles fine with latest FreeCAD HEAD. We should add it to snap edge in that case

@adrianinsaval
Copy link
Member

link to forum discussion: https://forum.freecadweb.org/viewtopic.php?p=639505#p639505

@luzpaz luzpaz added the help wanted Extra attention is needed label Dec 31, 2022
@adrianinsaval
Copy link
Member

you'll need to change this to V7_7_1_BF
https://github.com/FreeCAD/freecad-deps-core20-snap/blob/d58e75c254cb308d46dc522a6a3211767b092725/snap/snapcraft.yaml#L25

it's possible that you will need to move to core 22 also:
https://github.com/FreeCAD/freecad-deps-core20-snap/blob/d58e75c254cb308d46dc522a6a3211767b092725/snap/snapcraft.yaml#L2

occt 7.7 requires tbb >=2021.5 which I doubt would be in ubuntu 20.04

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 30, 2023

occt 7.7 requires tbb >=2021.5 which I doubt would be in ubuntu 20.04

You're right, @adrianinsaval. Do you know if I can keep things as they are for stable and change OCC and core 22 just for snap edge and snap beta builds?

  Ubuntu 20.04 package Packaging status

@adrianinsaval
Copy link
Member

I would expect yes, but I'm not all that familiar with how making snaps work

@luzpaz luzpaz changed the title Update to OCC 7.7.0 Update snap edge/beta to OCC 7.7.1 May 5, 2023
@luzpaz luzpaz moved this to Todo in Release Dashboard May 5, 2023
@adrianinsaval
Copy link
Member

adrianinsaval commented Jun 18, 2023

There's some bugs with occt 7.7.1 that I don't think we're going to fix before release, I'll move this out of the 0.21 project. Better to do this next cycle.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Aug 12, 2023

@chennes
Copy link
Member

chennes commented Aug 12, 2023

Are we not building Blobfish for the snaps? I should fix if not.

@adrianinsaval
Copy link
Member

we are using blobfish: https://github.com/FreeCAD/freecad-deps-snap/blob/d58e75c254cb308d46dc522a6a3211767b092725/snap/snapcraft.yaml#L24-L25

@luzpaz
Copy link
Collaborator Author

luzpaz commented Aug 12, 2023

has blobfish rebased his patches on 7.7.2 yet ?

@luzpaz luzpaz changed the title Update snap edge/beta to OCC 7.7.1 Update snap edge/beta to OCC 7.7.2 Aug 12, 2023
@chennes
Copy link
Member

chennes commented Aug 13, 2023

I don't think so: the latest I see is 7.7.1BF
https://gitlab.com/blobfish/occt/-/tree/V7_7_1_BF?ref_type=heads

@adrianinsaval
Copy link
Member

the blobfish patch set keeps growing but none of it is going upstream, should we worry about that? Can we do something to get those merged upstream?

@luzpaz
Copy link
Collaborator Author

luzpaz commented Aug 17, 2023

Maybe we can forge a relationship with upstream (there is a gentleman that has represented OCC in previous FLOSS conferences) and have a (paid?) liason work to merge patches ?

@chennes
Copy link
Member

chennes commented Aug 17, 2023

We cannot "merge" his code upstream, he has not signed the OpenCASCADE developer agreement, and is not interested in doing so. His patches would have to be rewritten.

@adrianinsaval
Copy link
Member

Ugh, I wish they would drop that silly requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants