-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FS Chat] Chat input glitches #217
Comments
Same issue here since a few weeks. Furthermore nothing happens if I click on the emote icon to the right. |
I have also been having this issue for a few weeks. Fullscreen chat is basically UN-useable for chatting. Colon auto complete doesn't work for emotes. Pressing enter adds a new line instead of sending the message. It's a broken mess. |
The emote menu, emote autocomplete and messaging is still broken. Mac OS and Windows 11, Chrome latest versions on both. |
Still unusable, Firefox and Chrome, Windows and Linux. |
Can confirm. Full screen chat is still utterly broken. |
I wanted to comment on this, since it's been open for a while. This happened because of a change to the version of React. Previously, React was perfectly happy with letting me move a DOM node to a new parent element while maintaining its reactivity. That no longer works, which is why pretty much everything ends up breaking. To fix this, I need to either switch to a pure-CSS solution for making chat appear, which isn't feasible since it isn't within the fullscreen root. Alternatively, React has a portal system to allow you to re-render an element into another element. I have been experimenting with this, but something about the chat tree keeps breaking whenever I try. Just haven't gotten it working yet, though not for lack of trying. |
Thank you for looking into this. If you could override the fullscreen button to use a different element, below is a proof of concept for that, minus dragging controls and probably some other clean up. I full screen the div containing both the main element (video) and right sidebar (chat) and apply some styles to overlay the right sidebar over the other layers.
|
I haven't looked into changing the fullscreenElement target yet, but that's probably not an awful approach. Just depends on how well I can convince the player that yes, it's really in fullscreen mode. |
Unless something else depends on knowing the player is fullscreen, you could just scope those rules by toggling a class on the html element when the overridden fullscreen function runs. Seems to work as if it's full screen with those rules. |
Without sending the chat is sadly useless.. |
Yea…. doesn’t seem like they are going to fix it. Sucks. Was the only feature I used outside of emotes-which aren’t exclusive to this extension. |
I can't speak for this specific addon / feature as I've not worked on it but please know that FFZ is working within the limitations of what is provided by Twitch's own page (its scripts etc) to keep the best possible compatibility. As Stendec outlined a few posts further up there has been a change in said Twitch scripts that causes issues with moving an element of the page to another parent element (in this case the video player) This is more of a "it's difficult to fix" rather than a "we don't care to fix it" situation. Implementing a custom chat from scratch is also added tech debt that can become fragile and break at any point. |
Describe the bug
This issue is really hard to describe but I hope this recording can give you a good enough idea.
Screencast_20240505_120318.webm
1234
s andarst
s are in the correct order. (arst
is just the equivalent ofasdf
on a Colemak keyboard layout). Then, when I go into fullscreen, notice how this gets messed up.1234
s. As a result, it pauses the player when I press space, thinking I'm typing. I didn't capture it in this recording because it messes with the other glitch(es) I wanted to show.To reproduce
I hope it's clear from the recording.
Expected behavior
I expect input in FS Chat to behave the same as in a normal non-FS chat.
Environment
FFZ Logs (via FFZ Control Center > Home > Feedback >> Log):
The text was updated successfully, but these errors were encountered: