-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listenbrainz 'playing_now' Support #74
Comments
I like this idea and I'd like to expand it a little bit and have a "now playing" in the MS ui for every source it is monitoring as well as notification/webhook functionality. It's already tracking this information in order to determine when to scrobble. Going to work on this for a bit. |
That sounds like a great extension of the idea. I await the fleshed out update👍 |
* Implements generic Player state tracking when using MemorySource * State tracking will replace processRecentPlays and all its data structures * Tracks reported player position OR real-time listened when position not available * Records listened sessions for more exhaustive "listen to" duration and eventually comparing incoming data playedAt for dups * Uses own tracked data to calculate most likely player state (stopped/started/paused) as well as health (stale/orphaned from no data) * Tracks player's reported state, if provided
Hey @ARufenach just wanted to let you know progress is being made :) |
Looks great! Can't wait for the update. |
* Use listenbrainz 'playing-now' endpoint for MS player implementation * Do not use MS player as source of truth -- continue to use LZ listen history
@ARufenach you can try MS with now playing support for listenbrainz in the Caveat for how it works:
Additionally, player functionality is now enabled for lastfm sources. |
Ah I think I see...so what you are wanting is:
If this is correct this is not how I interpreted it 😅 the feature I introduced is for a Listenbrainz Source where MS gets the now_playing notification from LZ and displays it. I'll need to do some more research to see if sending a now_playing notification affects subsequent scrobbles -- or if LZ scrobbles based on now_playing -- and see about using the play to notify an MS client... |
Oh that's my bad, I should've been more specific in the initial request. I wasn't even aware that you could have Listenbrainz as a source. But yes, my request is to have a configured source (in my case Jellyfin) playing a track, have MS monitoring it and send Listenbrainz a now_playing payload such that when you're listening to a track, it displays as 'now playing' on Listenbrainz. Purely a nice-to-have feature. Sorry for the confusion! |
Listenbrainz has a feature that can track live listens using the 'playing_now' type instead of the 'single' type when submitting to the submit-listens endpoint. This would be a nice addition to see what's being listened to at the moment from the Listenbrainz side.
The text was updated successfully, but these errors were encountered: