feat(youtube)!: Use oauth-based api library for better stability #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxxMD
added
enhancement
This was referenced Oct 9, 2024
FoxxMD
force-pushed
the
GH-195/ytoauth
branch
4 times, most recently
from
86d34bc
to
72d79fc
Compare
|
I think something in 671056d broke logging a lot :D it seems that for everything it does, it creates a log file. My logs directory immediately fills up with thousands of mostly empty log files. Just to give you an idea, these are some of the log files (the ones that aren't empty), note the file names: |
|
@xathon the issue is a bug in the underlying log library first found here #214 (comment) . I have a PR opened to fix this that will get merged into this PR |
|
Ah, I didn't want to raise a separate issue since I had the PR image running and thought it came from that. But yay, DST magic at it again :D |
|
@FluffyClaws @xathon other than the DST issue how is this PR working for you? Have you experienced any of the issues reported in #195 (duplicate scrobbles) after using it? I need more feedback from users before I can merge this. |
|
I think there was something. I'll check on it in the next couple of days and report back. |
Should fix new way YTM orders recent history #195
FoxxMD
force-pushed
the
GH-195/ytoauth
branch
from
46d93c7
to
34356c6
Compare
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
|
The latest |
|
Can confirm that there are no duplicate scrobbles the past few days. Only thing that I see is that the timestamps don't appear in the web log, the lines look like this: |
|
Thanks for the feedback. The missing timestamps are intentional since MS is showing you what info it received from YTM (it doesn't have timestamps). |
|
Hey, sorry, I have to retract my confirmation. I checked the wrong place, since in the web log of multiscrobbler they show up as single, but in Maloja they're duplicated. Excerpt from the log when this happens: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
Describe your changes
Migrate from youtube-music-ts-api, which only supports cookie-based auth -- to Youtube.js, which uses oauth auth.
Usage
Start multi-scrobbler with any existing YTM configuration. A log statement will prompt the user to visit a URL with a code (or it can be accessed from the dashboard)
Visit the URL and enter the code, then finish the auth flow. Afterwards, refresh the dashboard and click Start on the Idle YTM source to start polling.
Issue number and link, if applicable