Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The installer does not ask where to install #7

Open
Neustradamus opened this issue Feb 29, 2024 · 3 comments
Open

The installer does not ask where to install #7

Neustradamus opened this issue Feb 29, 2024 · 3 comments

Comments

@Neustradamus
Copy link

Dear @FoxP,

Thanks for your project.

I have a problem, the installer does not ask where I would like to install.
I can not to install in default software folder -> Program Files for example.
Can you create a good install which permit to select where to install and by default in Program Files ?

Thanks in advance.

@FoxP
Copy link
Owner

FoxP commented Feb 29, 2024

Hello,
You can use the portable version : https://github.com/FoxP/PNG-to-ICO/releases/download/v1.0/png_to_ico_portable.zip
King regards

@Neustradamus
Copy link
Author

It is needed to edit the .nsi to permit the folder install folder choice and have by default the "Program Files" or "Program Files (x86)":

After, it is needed to create a new release build with 2 installers -> 1 x86 and 1 x64 .exe.
You can have one build more with userdata folder too.

@FoxP
Copy link
Owner

FoxP commented May 2, 2024

This script is a simple .bat file, not a full-featured software : spending time on the installer / NSI is a little bit "overkill" in my opinion. But anyway, don't hesitate to submit a pull request for this, I'll be happy to merge it. 👍

A single .nsi would be the best option. But to be able to prompt the user to chose his/her own installation directory, you must use a NSIS plugin : https://nsis.sourceforge.io/Docs/nsDialogs/Readme.html
Have a look at nsDialogs::SelectFileDialog and nsDialogs::SelectFolderDialog.

@FoxP FoxP mentioned this issue May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants