You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In your documentation, you provide a whole section about using rollbax in Plug-based applications. How about adding a default plug implementation?
We could even copy & paste the implementation from the sentry.io project (MIT Licence) including tests.
Sure, we could write our own module (90% of the required code is in your documentation already), but we start new applications every 2-3 months and copy & paste this module all the time. We could write our own hex package just for this use case, but before we do this, I just want to ask you, if you could imagine adding a default plug implementation to rollbax directly? Should I submit a Pull Request?
The text was updated successfully, but these errors were encountered:
Just to bump this one a bit: I've recently opened PR #115 and #116, both containing improvements in the example code for Plug-based applications.
In addition to the reasons stated above, for improvements like this, it would also be great to have a default implementation included in Rollbar, as it enables us to include fixes and improvements in new releases.
I'm willing to help with this if the rollbax maintainers are positive about such an addition!
Hey guys.
In your documentation, you provide a whole section about using
rollbax
in Plug-based applications. How about adding a default plug implementation?We could even copy & paste the implementation from the sentry.io project (MIT Licence) including tests.
Sure, we could write our own module (90% of the required code is in your documentation already), but we start new applications every 2-3 months and copy & paste this module all the time. We could write our own hex package just for this use case, but before we do this, I just want to ask you, if you could imagine adding a default plug implementation to
rollbax
directly? Should I submit a Pull Request?The text was updated successfully, but these errors were encountered: