Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and Warning color coding in log section does not apply to Windows client #211

Open
muziqaz opened this issue Oct 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@muziqaz
Copy link

muziqaz commented Oct 27, 2024

In Linux client, Errors are color coded as red, and Warnings as yellow. This is extremely useful when troubleshooting or scrolling through the logs within fahclient web ui.
Windows clients for me are color blind. Would be great to have same color coding.
Linux
linux

Windows
windows

Thanks

@jcoffland
Copy link
Member

The reason is that the Windows console cannot interpret ANSI color codes and so you see a bunch of garbage on Windows with color logging enabled. However, in v8, Web Control reinterprets the ANSI codes from the log as HTML.

You can actually manually turn color logging on by adding a config.xml with at least this:

<config>
  <log-color/>
</config>

On Windows it's just defaulted to off. It's probably time to default log-color on for Windows since few people are looking at the logs directly. One issue is that if you open the log files in Windows with most editors you will see all the ugly ANSI color codes which make it almost unreadable.

@jcoffland jcoffland added the enhancement New feature or request label Nov 8, 2024
@muziqaz
Copy link
Author

muziqaz commented Nov 8, 2024

Would it be easier to do different font? If that is even possible

@jcoffland
Copy link
Member

There are no fonts in text files. So not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants