-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better errors for un-implemented functions #427
Labels
Comments
mcabbott
changed the title
Better errors without NNlibCUDA
Better errors ~~without NNlibCUDA~~ for un-implemented functions
Jun 22, 2023
mcabbott
changed the title
Better errors ~~without NNlibCUDA~~ for un-implemented functions
Better errors for un-implemented functions
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Functions like gather/scatter give scalar indexing errors if used on CuArrays without remembering to load NNlibCUDA.
Since there is now a very lightweight GPUArraysCore, I think NNlib should depend on that, and define dumb methods on
::AbstractGPUArray
which throw a helpful error.Edit, 2023:
After #492 we use extensions. If I understand right it may still be possible to forget to load cuDNN.
Some kernels don't yet work for Metal / AMDGPU, e.g. FluxML/Flux.jl#2278 . Here too it would be nicer to get a clear "not implemented" error.
The text was updated successfully, but these errors were encountered: