Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip for non native functions to lower false positives #31

Open
jmarcil opened this issue Dec 13, 2018 · 1 comment
Open

Add skip for non native functions to lower false positives #31

jmarcil opened this issue Dec 13, 2018 · 1 comment

Comments

@jmarcil
Copy link
Collaborator

jmarcil commented Dec 13, 2018

Following PR #20, we have other sniffers that could benefit from suppressing issues when ParanoiaMode == 0.

Watch out to not touch things such as mysqli::query (valid equivalent of mysqli_query).

@jmarcil
Copy link
Collaborator Author

jmarcil commented Aug 4, 2019

Looks like the solution from #20 and #42 could be applied to all non object based functions:

Validate if the token before is a T_OBJECT_OPERATOR and then skip it if it is.

On thing I need to put emphasis here for later: on a per bunch of function basis it's okay to remove even if paranoia is enabled, but for more broad changes I'd like it not to suppress results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant