Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editing name of object overwrites custom image #247

Open
nftchance opened this issue Mar 27, 2023 · 1 comment
Open

fix: editing name of object overwrites custom image #247

nftchance opened this issue Mar 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nftchance
Copy link
Contributor

#246 introduces a new bug I had not planned for where the name is changed, and then we generate a new image for them.

If they are using an auto-generated image, we want to update the image any time they update the name; however, if they are not using an auto-generated image, then we need to leave it so that we do not overwrite custom images a user uploads.

@nftchance nftchance added the bug Something isn't working label Mar 27, 2023
@nftchance nftchance added this to the v6 milestone Mar 27, 2023
@nftchance nftchance self-assigned this Mar 27, 2023
@nftchance
Copy link
Contributor Author

This is actually quite simple to fix with a little lock if we are on a form of an object that already exists. When the lock is checked, don't generate a new image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant