Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement change requests for change requests #4465

Open
rolodato opened this issue Aug 8, 2024 · 0 comments
Open

Implement change requests for change requests #4465

rolodato opened this issue Aug 8, 2024 · 0 comments
Labels
api Issue related to the REST API feature New feature or request

Comments

@rolodato
Copy link
Member

rolodato commented Aug 8, 2024

Is your feature request related to a problem? Please describe.

When working in an environment that has approvals enabled for feature changes, making modifications to an already-approved change request does not require approval. This means that users can ship unapproved schedule or content changes by editing an already-approved change request to have whatever value or date they want.

Describe the solution you'd like.

Trying to edit approved change requests should require approval, the same way trying to edit features does.

Editing unapproved change requests should not require approval, though we should reject edits if a user tries to approve an earlier version of a change request.

Describe alternatives you've considered

As a stopgap solution, it might be simpler to disallow editing approved change requests within environments that require approvals altogether. This would solve the immediate issue while not locking us in to a specific solution in the future.

Additional context

GitHub can require approval on pull requests, but by default allows merging changes that were pushed to a branch after the PR was initially approved without requiring further approval. An option can be enabled to change this: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule

@rolodato rolodato added feature New feature or request api Issue related to the REST API labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant