Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Audit - Improve the trait input field when creating segment definitions #343

Open
dabeeeenster opened this issue Sep 22, 2021 · 7 comments
Assignees
Labels
api Issue related to the REST API feature New feature or request improvement Improvement to the existing platform
Milestone

Comments

@dabeeeenster
Copy link
Contributor

The trait field:

image

Should be better/more intelligent. It should be a combined autocomplete/dropdown/free text element.

Populating the drop down

With the global API this is going to be tricky as we don't store a canonical list of trait keys. A 99% solution would be to grab ~50 identities at random and create a list of distinct trait keys from that data. This would be a significant improvement over the current implementation.

We would need to create an API endpoint to return this list.

@dabeeeenster dabeeeenster added feature New feature or request improvement Improvement to the existing platform api Issue related to the REST API labels Sep 22, 2021
@kyle-ssg
Copy link
Member

kyle-ssg commented Oct 22, 2021

Theres already an endpoint that would allow this, environments/:id/trait-keys/ but I guess we need that on the project level?

@dabeeeenster
Copy link
Contributor Author

Hmm yes - and also this data is not going to be accessible when we deploy the Global API. Needs some thought on how we can keep a list of distinct trait keys within a project cc @gagantrivedi @matthewelwell

@kyle-ssg
Copy link
Member

Ah, this will be a breaking change to the frontend in that case, we display global traits in the users list page

@dabeeeenster
Copy link
Contributor Author

Started a discussion at #437

@kyle-ssg
Copy link
Member

I'll need API before I can work on this

@kyle-ssg kyle-ssg removed their assignment Apr 10, 2022
@agerlic
Copy link

agerlic commented Sep 4, 2023

Hello, is there are any updates regarding the resolution of this issue?

@dabeeeenster
Copy link
Contributor Author

We're not currently working on this feature I'm afraid. It's technically complex with our Edge API.

@kyle-ssg kyle-ssg added this to the UX Audit 2023 milestone Feb 28, 2024
@kyle-ssg kyle-ssg changed the title Improve the trait input field when creating segment definitions UX Audit - Improve the trait input field when creating segment definitions Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request improvement Improvement to the existing platform
Projects
None yet
Development

No branches or pull requests

5 participants