Add/improve support for native JSON APIs #41
Labels
enhancement
New feature or request
Milestone
Comments
This was referenced Nov 15, 2023
Firehed
added a commit
that referenced
this issue
Nov 17, 2023
This adds response parsers for the recently-added [toJSON()](https://www.w3.org/TR/webauthn-3/#dom-publickeycredential-tojson) response formats. Progress towards #41, which will be completed when there's message generators that complement the `PublicKeyCredential.parse{Creation|Request}OptionsFromJSON()` methods.
This was referenced Nov 17, 2023
Firehed
added a commit
that referenced
this issue
Nov 18, 2023
The conversion is only really done in the context of a BinaryString, so having the logic split out into a different class didn't make a lot of sense. As a result, it's being consolidated. In addition to organization, this should make completion of #41 easier, specifically for emitting formats that match `PublicKeyCredential.parse{Creation|Request}OptionsFromJSON()` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The next draft of WebAuthn (level 3) adds some major ergonomic improvements to the client side of the flows:
static PublicKeyCredential.parseCreationOptionsFromJSON()static PublicKeyCredential.parseRequestOptionsFromJSON()PublicKeyCredential.toJSON()These methods collectively remove a lot of fussiness from client code, particularly around ArrayBuffer handling. They also add a de-facto standard wire format for client-to-server communication.
While these are only (as of writing) supported natively in Firefox, there's a library available to aid the transition until it has wider support (while experimenting with it, it did appear to deviate from the spec in the sense that some
requiredfields were not present, but this should be inconsequential)The library should add native support for these formats, as it can greatly improve ergonomics. I'm inclined to retain support for the original versions as well, since browser support may take a while and not everyone will want or be able to use the library. It's also well-tested and updating tests vectors may introduce unnecessary risk. Having said that, supporting only a single format is nice.
The text was updated successfully, but these errors were encountered: